testing/test_env.py - Issue 645033003: Pass G_SLICE=always-malloc to swarmed ASan tasks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: testing/test_env.py

Issue 645033003: Pass G_SLICE=always-malloc to swarmed ASan tasks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: testing/test_env.py

diff --git a/testing/test_env.py b/testing/test_env.py

index 0539309fd59c48c43a2a3baa55d863c768ed01b2..574aaed880eacd186e4a63daf389470800c33a92 100755

--- a/testing/test_env.py

+++ b/testing/test_env.py

@@ -81,10 +81,7 @@ def get_asan_env(cmd, lsan):

extra_env = {}

# Instruct GTK to use malloc while running ASan or LSan tests.

- # TODO(earthdok): enabling G_SLICE gives these leaks, locally and on swarming

- #0 0x62c01b in __interceptor_malloc (/tmp/run_tha_testXukBDT/out/Release/browser_tests+0x62c01b)

- #1 0x7fb64ab64a38 in g_malloc /build/buildd/glib2.0-2.32.4/./glib/gmem.c:159

- #extra_env['G_SLICE'] = 'always-malloc'

+ extra_env['G_SLICE'] = 'always-malloc'

extra_env['NSS_DISABLE_ARENA_FREE_LIST'] = '1'

extra_env['NSS_DISABLE_UNLOAD'] = '1'

« no previous file with comments | « no previous file | no next file » | no next file with comments »