Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1517)

Unified Diff: Source/modules/credentialmanager/Credential.h

Issue 645023005: Credential Manager: Add a 'formData' property to LocalCredential. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git/+/reordering-arguments
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/credentialmanager/Credential.h
diff --git a/Source/modules/credentialmanager/Credential.h b/Source/modules/credentialmanager/Credential.h
index 5e195eeb27e3c6812c47b188bad14dd27b3f0bd9..46816149e12159963c4599afd530200b705a0695 100644
--- a/Source/modules/credentialmanager/Credential.h
+++ b/Source/modules/credentialmanager/Credential.h
@@ -16,7 +16,7 @@ namespace blink {
class WebCredential;
class ExceptionState;
-class Credential : public GarbageCollected<Credential>, public ScriptWrappable {
+class Credential : public GarbageCollectedFinalized<Credential>, public ScriptWrappable {
Mike West 2014/10/20 08:05:11 Is there a way to avoid finalizing Credential? If
haraken 2014/10/20 08:16:03 Why can't you simply use GarbageCollected<Credenti
sof 2014/10/20 08:18:53 It's due to the LocalCredential change made here.
DEFINE_WRAPPERTYPEINFO();
public:
static Credential* create(const String& id, const String& name, const KURL& avatar);

Powered by Google App Engine
This is Rietveld 408576698