LayoutTests/fast/multicol/composited-relpos-clipped.html - Issue 645023002: [New Multicolumn] Make layer bounding boxes visual and relative to "root".

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/multicol/composited-relpos-clipped.html

Issue 645023002: [New Multicolumn] Make layer bounding boxes visual and relative to "root". (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Code review. Improved comment. Use will-change where possible. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/fast/multicol/composited-relpos.html ('K') | « LayoutTests/fast/multicol/composited-relpos.html ('k') | LayoutTests/fast/multicol/composited-relpos-clipped-expected.html » ('j') | LayoutTests/fast/multicol/composited-with-child-layer-in-next-column.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <p>There should be two yellow boxes below, on a blue background.</p>

	3 <div style="-webkit-columns:2; column-fill:auto; height:13em; line-height:2em;">

	4 <div style="will-change:transform; position:absolute; left:0; right:0; heigh t:13em; background:blue;"></div>
	Julien - ping for review 2014/10/13 19:25:02 You forgot this will-change:transform. You forgot this will-change:transform. mstensho (USE GERRIT) 2014/10/13 20:47:25 Sorry, what do you mean? Show quoted text On 2014/10/13 19:25:02, Julien Chaffraix - PST wrote: > You forgot this will-change:transform. Sorry, what do you mean? Julien - ping for review 2014/10/14 17:53:51 There was an earlier comment about not using will- Show quoted text On 2014/10/13 20:47:25, mstensho wrote: > On 2014/10/13 19:25:02, Julien Chaffraix - PST wrote: > > You forgot this will-change:transform. > > Sorry, what do you mean? There was an earlier comment about not using will-change:transform but a transform:translateZ(0) instead. Just saying that you changed the first test but forgot the following. mstensho (USE GERRIT) 2014/10/14 18:11:31 Ah, no, it was the other way around, about changin Show quoted text On 2014/10/14 17:53:51, Julien Chaffraix - PST wrote: > On 2014/10/13 20:47:25, mstensho wrote: > > On 2014/10/13 19:25:02, Julien Chaffraix - PST wrote: > > > You forgot this will-change:transform. > > > > Sorry, what do you mean? > > There was an earlier comment about not using will-change:transform but a > transform:translateZ(0) instead. Just saying that you changed the first test but > forgot the following. Ah, no, it was the other way around, about changing to using will-change, instead of transform. So I changed to using will-change, except for one test, because then it would fail. I'd rather deal with that in a separate CL, if that's okay with you.
	5 <br>

	6 <br>

	7 <br>

	8 <br>

	9 <div style="position:relative; overflow:hidden; margin:0.5em; height:8.5em; background:yellow;">

	10 first<br>

	11 column<br>

	12 second<br>

	13 column<br>

	14 <div style="background:red;">FAIL</div>

	15 </div>

	16 </div>

OLD	NEW