Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 644993002: X64: replace explicit zero-extend with runtime assert (Closed)

Created:
6 years, 2 months ago by Weiliang
Modified:
6 years, 1 month ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

X64: replace explicit zero-extend with runtime assert Since the input float64 is in the range of [0, 2^32-1], the upper 32 bits of output register should be zero. BUG= R=bmeurer@chromium.org, titzer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25027

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M src/compiler/x64/code-generator-x64.cc View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Weiliang
PTAL
6 years, 2 months ago (2014-10-10 08:48:28 UTC) #2
titzer
lgtm
6 years, 2 months ago (2014-10-15 12:10:53 UTC) #3
Benedikt Meurer
I think this is NOT LGTM. We should really get the 32 vs 64 int/uint ...
6 years, 2 months ago (2014-10-17 09:48:48 UTC) #4
Benedikt Meurer
Ok, so Ben convinced me that this is the way to go. So, LGTM. Will ...
6 years, 1 month ago (2014-10-31 09:18:15 UTC) #5
Benedikt Meurer
6 years, 1 month ago (2014-10-31 09:20:00 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 25027 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698