Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 644983002: Revert of Remove Overlay Scrollbar if not scrollable along the axis (patchset #9 id:1140001 of http… (Closed)

Created:
6 years, 2 months ago by apavlov
Modified:
6 years, 2 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, blink-layers+watch_chromium.org, jchaffraix+rendering, rune+blink
Project:
blink
Visibility:
Public.

Description

Revert of Remove Overlay Scrollbar if not scrollable along the axis (patchset #9 id:1140001 of https://codereview.chromium.org/588013002/) Reason for revert: This has resulted in multiple webkit_unit_tests crashes on android_dbg_tests_recipe, blocking a Blink roll. Original issue's description: > Remove Overlay Scrollbar if not scrollable along the axis > > Remove Overlay Scrollbar if not scrollable along that axis. If the > scrollSize along that axis is zero then set scrollbar along that > axis to false. This is applicable to Solid-Color scrollbars in Android > & Overlay scrollbars in the Aura. > > BUG=415031 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183445 TBR=enne@chromium.org,vollick@chromium.org,sataya.m@samsung.com NOTREECHECKS=true NOTRY=true BUG=415031 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183520

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -109 lines) Patch
D LayoutTests/fast/forms/select/listbox-nooverlay-scrollbar.html View 1 chunk +0 lines, -35 lines 0 comments Download
D LayoutTests/fast/forms/select/listbox-nooverlay-scrollbar-expected.html View 1 chunk +0 lines, -25 lines 0 comments Download
M LayoutTests/fast/forms/select/listbox-overlay-scrollbar.html View 2 chunks +2 lines, -16 lines 0 comments Download
M LayoutTests/fast/forms/select/listbox-overlay-scrollbar-expected.html View 2 chunks +0 lines, -13 lines 0 comments Download
M LayoutTests/fast/scrolling/overlay-scrollbars.html View 1 chunk +2 lines, -5 lines 0 comments Download
M LayoutTests/fast/scrolling/overlay-scrollbars-expected.html View 2 chunks +11 lines, -7 lines 0 comments Download
D LayoutTests/platform/linux/virtual/prefer_compositing_to_lcd_text/compositing/overflow/scroll-parent-with-non-stacking-context-composited-ancestor-expected.png View Binary file 0 comments Download
M LayoutTests/platform/win/compositing/overflow/scroll-parent-with-non-stacking-context-composited-ancestor-expected.png View Binary file 0 comments Download
M LayoutTests/platform/win/compositing/overflow/scroll-parent-with-non-stacking-context-composited-ancestor-expected.txt View 1 chunk +11 lines, -1 line 0 comments Download
M LayoutTests/platform/win/virtual/prefer_compositing_to_lcd_text/compositing/overflow/scroll-parent-with-non-stacking-context-composited-ancestor-expected.png View Binary file 0 comments Download
M LayoutTests/platform/win/virtual/prefer_compositing_to_lcd_text/compositing/overflow/scroll-parent-with-non-stacking-context-composited-ancestor-expected.txt View 1 chunk +11 lines, -1 line 0 comments Download
M Source/core/rendering/RenderLayerScrollableArea.cpp View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/644983002/1
6 years, 2 months ago (2014-10-10 08:36:15 UTC) #2
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 08:36:55 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 183520

Powered by Google App Engine
This is Rietveld 408576698