Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 644973003: MIPS: [turbofan] Make VisitBranch and friends to backend specific. (Closed)

Created:
6 years, 2 months ago by balazs.kilvady
Modified:
6 years, 2 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

MIPS: [turbofan] Make VisitBranch and friends to backend specific. Port r24546 (c3443cd) Original commit message: This is required to fix a tricky branch fusion bug on ARM, which was caused by the interaction between the architecture-independent and architecture-specific parts of the InstructionSelector. In the end it wasn't worth sharing a few common lines of code for the additional complexity, especially if we also want to properly support architectures without any dedicated flags register (i.e. MIPS). TEST=mjsunit,unittests BUG=

Patch Set 1 #

Patch Set 2 : Add VisitBranch() with UNIMPLEMTED() body #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -44 lines) Patch
M src/compiler/instruction-selector.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 4 chunks +138 lines, -44 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
paul.l...
This is a preliminary port of r24546, which should unbreak the build for mips. I'm ...
6 years, 2 months ago (2014-10-13 23:27:58 UTC) #2
Benedikt Meurer
lgtm
6 years, 2 months ago (2014-10-14 11:16:42 UTC) #3
paul.l...
6 years, 2 months ago (2014-10-14 17:28:04 UTC) #4
Committed as 24571. (on 13-September)

Powered by Google App Engine
This is Rietveld 408576698