Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 644973002: Conform to the unittest naming convention. (Closed)

Created:
6 years, 2 months ago by Yang
Modified:
6 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Conform to the unittest naming convention. R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24513

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -127 lines) Patch
A + test/unittests/char-predicates-unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
D test/unittests/unicode/unicode-predicates-unittest.cc View 1 chunk +0 lines, -121 lines 0 comments Download
M test/unittests/unittests.gyp View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 2 months ago (2014-10-10 08:04:40 UTC) #1
Benedikt Meurer
lgtm
6 years, 2 months ago (2014-10-10 08:05:16 UTC) #2
Yang
6 years, 2 months ago (2014-10-10 08:06:30 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24513 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698