chrome/browser/devtools/device/android_device_manager.cc - Issue 644963003: [DevTools] Port forwarding doesn't keep USB connection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/device/android_device_manager.cc

Issue 644963003: [DevTools] Port forwarding doesn't keep USB connection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/websocket

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/devtools/device/android_device_manager.h ('k') | chrome/browser/devtools/device/android_web_socket.cc » ('j') | chrome/browser/devtools/device/android_web_socket.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/devtools/device/android_device_manager.cc

diff --git a/chrome/browser/devtools/device/android_device_manager.cc b/chrome/browser/devtools/device/android_device_manager.cc

index df99de7ba9133b0c490a0e18b03ab166efa6b8c7..bc5e025b4bdbdd0fed518faa0115e983366885c3 100644

--- a/chrome/browser/devtools/device/android_device_manager.cc

+++ b/chrome/browser/devtools/device/android_device_manager.cc

@@ -389,6 +389,10 @@ AndroidDeviceManager::Device::Device(

}

AndroidDeviceManager::Device::~Device() {

+ std::set<AndroidWebSocket*> sockets_copy(sockets_);

+ for (AndroidWebSocket* socket : sockets_copy)

+ socket->Terminate();

dgozman 2014/10/21 11:54:02 I think this should issue Delegate::OnSocketClosed

vkuzkokov 2014/10/21 13:00:53 It should. Fixed.

provider_->AddRef();

DeviceProvider* raw_ptr = provider_.get();

provider_ = NULL;