Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 644953003: Store [-webkit-]transform-origin as a TransformOrigin. (Closed)

Created:
6 years, 2 months ago by andersr
Modified:
6 years, 2 months ago
Reviewers:
Timothy Loh
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-rendering, dglazkov+blink, dstockwell, eae+blinkwatch, ed+blinkwatch_opera.com, Eric Willigers, jchaffraix+rendering, leviw+renderwatch, Mike Lawther (Google), pdr+renderingwatchlist_chromium.org, rjwright, rwlbuis, rune+blink, shans, Steve Block, Timothy Loh, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Store [-webkit-]transform-origin as a TransformOrigin. This makes it possible to use a converter, and makes style/animation application cleaner. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183651

Patch Set 1 #

Patch Set 2 : Same patch, with correct base this time. #

Total comments: 2

Patch Set 3 : Remove unused include. #

Patch Set 4 : Almost forgot: drop unused ctor. (+ rebase). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -89 lines) Patch
M Source/core/animation/css/CSSAnimatableValueFactory.cpp View 1 2 chunks +9 lines, -4 lines 0 comments Download
M Source/core/css/CSSProperties.in View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/AnimatedStyleBuilder.cpp View 1 2 chunks +12 lines, -6 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderConverter.h View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderConverter.cpp View 1 2 3 1 chunk +16 lines, -0 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 1 2 3 1 chunk +0 lines, -60 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.h View 1 2 3 4 chunks +11 lines, -7 lines 0 comments Download
M Source/core/rendering/style/StyleTransformData.h View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M Source/core/rendering/style/StyleTransformData.cpp View 1 chunk +3 lines, -7 lines 0 comments Download
A Source/core/rendering/style/TransformOrigin.h View 1 2 3 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
andersr
6 years, 2 months ago (2014-10-10 12:21:38 UTC) #2
Timothy Loh
lgtm https://codereview.chromium.org/644953003/diff/140001/Source/core/rendering/style/TransformOrigin.h File Source/core/rendering/style/TransformOrigin.h (right): https://codereview.chromium.org/644953003/diff/140001/Source/core/rendering/style/TransformOrigin.h#newcode14 Source/core/rendering/style/TransformOrigin.h:14: TransformOrigin() { } Is this ctor ever used?
6 years, 2 months ago (2014-10-10 15:04:48 UTC) #3
Timothy Loh
https://codereview.chromium.org/644953003/diff/140001/Source/core/rendering/style/StyleTransformData.h File Source/core/rendering/style/StyleTransformData.h (right): https://codereview.chromium.org/644953003/diff/140001/Source/core/rendering/style/StyleTransformData.h#newcode29 Source/core/rendering/style/StyleTransformData.h:29: #include "platform/Length.h" unused include now
6 years, 2 months ago (2014-10-10 15:13:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/644953003/300001
6 years, 2 months ago (2014-10-14 06:51:41 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 07:57:20 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 (id:300001) as 183651

Powered by Google App Engine
This is Rietveld 408576698