Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 644923002: Revert "Add tests for File System URLs with the file:// origin." (Closed)

Created:
6 years, 2 months ago by hirono
Modified:
6 years, 2 months ago
Reviewers:
mtomasz
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert "Add tests for File System URLs with the file:// origin." The test is no longer needed. Reverted revision: crrev.com/293821 BUG=NONE TEST=NONE Committed: https://crrev.com/92cf3145675dc8eb6c40bac2951b091f2608765d Cr-Commit-Position: refs/heads/master@{#299072}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -158 lines) Patch
M chrome/browser/chromeos/file_manager/external_filesystem_apitest.cc View 1 chunk +0 lines, -9 lines 0 comments Download
D chrome/test/data/extensions/api_test/file_browser/filesystem_file_origin_url/background.js View 1 chunk +0 lines, -130 lines 0 comments Download
D chrome/test/data/extensions/api_test/file_browser/filesystem_file_origin_url/manifest.json View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
hirono
PTAL the CL? Thank you!
6 years, 2 months ago (2014-10-10 06:13:59 UTC) #2
mtomasz
lgtm
6 years, 2 months ago (2014-10-10 06:15:58 UTC) #3
hirono
On 2014/10/10 06:15:58, mtomasz wrote: > lgtm Thanks!
6 years, 2 months ago (2014-10-10 06:29:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/644923002/1
6 years, 2 months ago (2014-10-10 06:29:48 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-10 07:23:52 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 07:24:43 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/92cf3145675dc8eb6c40bac2951b091f2608765d
Cr-Commit-Position: refs/heads/master@{#299072}

Powered by Google App Engine
This is Rietveld 408576698