Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(819)

Issue 644913009: Clean up forward declarations in Source/platform (Closed)

Created:
6 years, 2 months ago by zhaoze.zhou
Modified:
6 years, 1 month ago
CC:
blink-reviews, krit, Rik, jbroman, mkwst+moarreviews_chromium.org, danakj, pdr+graphicswatchlist_chromium.org, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Clean up forward declarations in Source/platform These forward references are not needed anymore. After this patch, Source/platform has no unneeded forward references any more. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184466

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M Source/platform/PlatformScreen.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/graphics/Canvas2DImageBufferSurface.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/graphics/ImageFrameGenerator.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/heap/Heap.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/text/TextRun.h View 1 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
rwlbuis
On 2014/10/17 22:38:29, zhaoze.zhou wrote: > mailto:zhaoze.zhou@partner.samsung.com changed reviewers: > + mailto:rob.buis@samsung.com Can you check ...
6 years, 1 month ago (2014-10-27 14:04:22 UTC) #2
rwlbuis
On 2014/10/27 14:04:22, rwlbuis wrote: > On 2014/10/17 22:38:29, zhaoze.zhou wrote: > > mailto:zhaoze.zhou@partner.samsung.com changed ...
6 years, 1 month ago (2014-10-27 15:15:21 UTC) #5
rwlbuis
On 2014/10/27 14:04:22, rwlbuis wrote: > On 2014/10/17 22:38:29, zhaoze.zhou wrote: > > mailto:zhaoze.zhou@partner.samsung.com changed ...
6 years, 1 month ago (2014-10-27 15:15:23 UTC) #6
zhaoze.zhou
mkwst@chromium.org: Please take a look. thanks.
6 years, 1 month ago (2014-10-27 15:17:27 UTC) #8
Stephen Chennney
lgtm
6 years, 1 month ago (2014-10-27 15:35:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/644913009/60001
6 years, 1 month ago (2014-10-27 15:36:55 UTC) #12
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 16:59:35 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as 184466

Powered by Google App Engine
This is Rietveld 408576698