Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 644913008: Add Enterprise policy option to control minimum SSL fallback level. (Closed)

Created:
6 years, 2 months ago by agl
Modified:
6 years, 2 months ago
CC:
chromium-reviews, joaodasilva+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git/+/master
Project:
chromium
Visibility:
Public.

Description

Add Enterprise policy option to control minimum SSL fallback level. r299567 disabled SSLv3 fallback. This change adds an enterprise policy option to control this value so that enterprises can reenable the fallback if they need it. This option is in contrast to the one added in r299755. That one allows enterprises to be more aggressive in disabling SSLv3, while this one is intended for those who need to more slower that Chrome's default. BUG=418848, 419870 Committed: https://crrev.com/33369a4034528613b79464015cf8a000e3f27abb Cr-Commit-Position: refs/heads/master@{#300178}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -1 line) Patch
M chrome/browser/policy/configuration_policy_handler_list_factory.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 1 chunk +29 lines, -0 lines 0 comments Download
M chrome/test/data/policy/policy_test_cases.json View 1 chunk +6 lines, -0 lines 0 comments Download
M components/policy/resources/policy_templates.json View 2 chunks +58 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
agl
6 years, 2 months ago (2014-10-17 19:08:35 UTC) #2
Alexei Svitkine (slow)
histograms lgtm
6 years, 2 months ago (2014-10-17 19:08:59 UTC) #3
Joao da Silva
code lgtm However I don't quite understand how these 2 policies will interact. I thought ...
6 years, 2 months ago (2014-10-17 19:19:13 UTC) #4
agl
On 2014/10/17 19:19:13, Joao da Silva wrote: > code lgtm > > However I don't ...
6 years, 2 months ago (2014-10-17 20:12:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/644913008/1
6 years, 2 months ago (2014-10-17 22:09:52 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-17 22:28:23 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 22:29:33 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/33369a4034528613b79464015cf8a000e3f27abb
Cr-Commit-Position: refs/heads/master@{#300178}

Powered by Google App Engine
This is Rietveld 408576698