Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 644913006: Push API: Log registration success/failure codes to UMA (Closed)

Created:
6 years, 2 months ago by johnme
Modified:
6 years, 2 months ago
CC:
asvitkine+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, jam, Michael van Ouwerkerk
Base URL:
https://chromium.googlesource.com/chromium/src.git/+/master
Project:
chromium
Visibility:
Public.

Description

Push API: Log registration success/failure codes to UMA BUG=401438 Committed: https://crrev.com/1f125f14e0d2cb8980049baf43f1cb34d7307a4e Cr-Commit-Position: refs/heads/master@{#300532}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -8 lines) Patch
M content/browser/push_messaging_message_filter.cc View 5 chunks +19 lines, -2 lines 0 comments Download
M content/public/common/push_messaging_status.h View 2 chunks +15 lines, -6 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
johnme
isherman@chromium.org: Please review changes in tools/metrics/histograms jochen@chromium.org: Please review changes in content/
6 years, 2 months ago (2014-10-17 17:30:58 UTC) #2
Michael van Ouwerkerk
lgtm for Push API changes, but I'm not an owner
6 years, 2 months ago (2014-10-17 18:01:11 UTC) #4
Ilya Sherman
Histograms LGTM.
6 years, 2 months ago (2014-10-17 22:38:37 UTC) #5
jochen (gone - plz use gerrit)
lgtm
6 years, 2 months ago (2014-10-20 13:37:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/644913006/1
6 years, 2 months ago (2014-10-21 15:25:30 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/27665)
6 years, 2 months ago (2014-10-21 17:19:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/644913006/1
6 years, 2 months ago (2014-10-21 18:25:05 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-21 19:09:04 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 19:09:53 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1f125f14e0d2cb8980049baf43f1cb34d7307a4e
Cr-Commit-Position: refs/heads/master@{#300532}

Powered by Google App Engine
This is Rietveld 408576698