Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 644903002: Replacing the OVERRIDE with override and in chrome (Closed)

Created:
6 years, 2 months ago by MRV
Modified:
6 years, 2 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replacing the OVERRIDE with override and in chrome This step is a giant search and replace for OVERRIDE to replace them with their lowercase versions. BUG=417463 Committed: https://crrev.com/0553ad50a433772e71adda9f7060774e4eafe65e Cr-Commit-Position: refs/heads/master@{#299062}

Patch Set 1 #

Patch Set 2 : Extrafile added #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -62 lines) Patch
M chrome/android/shell/chrome_main_delegate_chrome_shell_android.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/shell/chrome_shell_google_location_settings_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/sync_shell/chrome_main_delegate_chrome_sync_shell_android.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/app/android/chrome_main_delegate_android.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/app/chrome_crash_reporter_client.h View 1 chunk +21 lines, -21 lines 0 comments Download
M chrome/app/chrome_main_delegate.h View 1 chunk +15 lines, -15 lines 0 comments Download
M chrome/app/client_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/app/delay_load_hook_unittest_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/signature_validator_win_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/app_shim/chrome_main_app_mode_mac.mm View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/settings_overrides_handler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/ui_overrides_handler.h View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/permissions/chrome_permission_message_provider.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/plugin/chrome_content_plugin_client.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
MRV
Files which are left in chrome folder for OVERRIDE PTAL
6 years, 2 months ago (2014-10-10 03:48:32 UTC) #2
MRV
On 2014/10/10 03:48:32, MRV wrote: > Files which are left in chrome folder for OVERRIDE ...
6 years, 2 months ago (2014-10-10 03:55:39 UTC) #3
Lei Zhang
lgtm
6 years, 2 months ago (2014-10-10 04:29:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/644903002/180001
6 years, 2 months ago (2014-10-10 04:30:20 UTC) #6
MRV
On 2014/10/10 04:29:45, Lei Zhang wrote: > lgtm Thanks mr. Lei Zhang
6 years, 2 months ago (2014-10-10 04:31:10 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:180001)
6 years, 2 months ago (2014-10-10 05:25:41 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 05:26:25 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0553ad50a433772e71adda9f7060774e4eafe65e
Cr-Commit-Position: refs/heads/master@{#299062}

Powered by Google App Engine
This is Rietveld 408576698