Pref to update daily content lengths with the latest values.

Pref to update daily content lengths with the latest values.

When this pref is set, the daily content length prefs are updated
with the latest values from memory.

BUG=411540
Committed: https://crrev.com/5e7bd1206f1e6bfd1adb45bcc823d457bdad8ae2
Cr-Commit-Position: refs/heads/master@{#301752}

[Not at Google. Contact bengr, 2014-10-24 23:28:59]

kundaji@chromium.org changed reviewers:
+ bengr@chromium.org

[Not at Google. Contact bengr, 2014-10-24 23:29:35]

bengr:
  components/data_reduction_proxy/core/browser/data_reduction_proxy_prefs.cc
 
components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics_prefs.cc
 
components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics_prefs.h
  components/data_reduction_proxy/core/common/data_reduction_proxy_pref_names.cc
  components/data_reduction_proxy/core/common/data_reduction_proxy_pref_names.h

[bengr, 2014-10-27 21:47:39]

https://codereview.chromium.org/644883006/diff/20001/components/data_reductio...
File components/data_reduction_proxy/core/browser/data_reduction_proxy_prefs.cc
(right):

https://codereview.chromium.org/644883006/diff/20001/components/data_reductio...
components/data_reduction_proxy/core/browser/data_reduction_proxy_prefs.cc:196:
profile_prefs->SetBoolean(
No need to migrate this pref since it's new.

https://codereview.chromium.org/644883006/diff/20001/components/data_reductio...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics_prefs.cc
(right):

https://codereview.chromium.org/644883006/diff/20001/components/data_reductio...
components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics_prefs.cc:82:
void DataReductionProxyStatisticsPrefs::OnUpdateContentLengths() {
This needs a test that demonstrates that the daily prefs are updated when you
set this pref.

https://codereview.chromium.org/644883006/diff/20001/components/data_reductio...
components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics_prefs.cc:84:
if (pref_service_->GetBoolean(prefs::kUpdateDailyReceivedContentLengths)) {
I prefer this style:

if (!...GetBoolean(...))
  return;
WritePrefs();
...SetBoolean(..., false);

https://codereview.chromium.org/644883006/diff/20001/components/data_reductio...
File
components/data_reduction_proxy/core/common/data_reduction_proxy_pref_names.cc
(right):

https://codereview.chromium.org/644883006/diff/20001/components/data_reductio...
components/data_reduction_proxy/core/common/data_reduction_proxy_pref_names.cc:60:
// value. These values is cached in memory on platforms other than Android and
is -> are

https://codereview.chromium.org/644883006/diff/20001/components/data_reductio...
File
components/data_reduction_proxy/core/common/data_reduction_proxy_pref_names.h
(right):

https://codereview.chromium.org/644883006/diff/20001/components/data_reductio...
components/data_reduction_proxy/core/common/data_reduction_proxy_pref_names.h:23:
extern const char kUpdateDailyReceivedContentLengths[];
Alphabetize.

[Not at Google. Contact bengr, 2014-10-28 00:45:52]

https://codereview.chromium.org/644883006/diff/20001/components/data_reductio...
File components/data_reduction_proxy/core/browser/data_reduction_proxy_prefs.cc
(right):

https://codereview.chromium.org/644883006/diff/20001/components/data_reductio...
components/data_reduction_proxy/core/browser/data_reduction_proxy_prefs.cc:196:
profile_prefs->SetBoolean(
On 2014/10/27 21:47:39, bengr wrote:
> No need to migrate this pref since it's new.

Done.

https://codereview.chromium.org/644883006/diff/20001/components/data_reductio...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics_prefs.cc
(right):

https://codereview.chromium.org/644883006/diff/20001/components/data_reductio...
components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics_prefs.cc:82:
void DataReductionProxyStatisticsPrefs::OnUpdateContentLengths() {
On 2014/10/27 21:47:39, bengr wrote:
> This needs a test that demonstrates that the daily prefs are updated when you
> set this pref.

Done.

https://codereview.chromium.org/644883006/diff/20001/components/data_reductio...
components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics_prefs.cc:84:
if (pref_service_->GetBoolean(prefs::kUpdateDailyReceivedContentLengths)) {
On 2014/10/27 21:47:39, bengr wrote:
> I prefer this style:
> 
> if (!...GetBoolean(...))
>   return;
> WritePrefs();
> ...SetBoolean(..., false);

Done.

https://codereview.chromium.org/644883006/diff/20001/components/data_reductio...
File
components/data_reduction_proxy/core/common/data_reduction_proxy_pref_names.cc
(right):

https://codereview.chromium.org/644883006/diff/20001/components/data_reductio...
components/data_reduction_proxy/core/common/data_reduction_proxy_pref_names.cc:60:
// value. These values is cached in memory on platforms other than Android and
On 2014/10/27 21:47:39, bengr wrote:
> is -> are

Done.

https://codereview.chromium.org/644883006/diff/20001/components/data_reductio...
File
components/data_reduction_proxy/core/common/data_reduction_proxy_pref_names.h
(right):

https://codereview.chromium.org/644883006/diff/20001/components/data_reductio...
components/data_reduction_proxy/core/common/data_reduction_proxy_pref_names.h:23:
extern const char kUpdateDailyReceivedContentLengths[];
On 2014/10/27 21:47:39, bengr wrote:
> Alphabetize. 

Done.

[Not at Google. Contact bengr, 2014-10-28 00:46:23]

kundaji@chromium.org changed reviewers:
+ rlp@chromium.org

[Not at Google. Contact bengr, 2014-10-28 00:46:40]

bengr:
  components/data_reduction_proxy/core/browser/data_reduction_proxy_prefs.cc
 
components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics_prefs.cc
 
components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics_prefs.h
 
components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics_prefs_unittest.cc
  components/data_reduction_proxy/core/common/data_reduction_proxy_pref_names.cc
  components/data_reduction_proxy/core/common/data_reduction_proxy_pref_names.h

rlp:
  chrome/browser/profiles/profile_io_data.cc

[bengr, 2014-10-28 21:11:45]

lgtm with nit.

https://codereview.chromium.org/644883006/diff/40001/components/data_reductio...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics_prefs_unittest.cc
(right):

https://codereview.chromium.org/644883006/diff/40001/components/data_reductio...
components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics_prefs_unittest.cc:177:
base::TimeDelta::FromMinutes(kWriteDelayMinutes)));
#include "base/time/time.h"

[Not at Google. Contact bengr, 2014-10-28 22:44:54]

https://codereview.chromium.org/644883006/diff/40001/components/data_reductio...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics_prefs_unittest.cc
(right):

https://codereview.chromium.org/644883006/diff/40001/components/data_reductio...
components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics_prefs_unittest.cc:177:
base::TimeDelta::FromMinutes(kWriteDelayMinutes)));
On 2014/10/28 21:11:45, bengr wrote:
> #include "base/time/time.h"

Good catch. Done.

[Not at Google. Contact bengr, 2014-10-28 22:46:55]

kundaji@chromium.org changed reviewers:
+ mmenke@chromium.org
- rlp@chromium.org

[Not at Google. Contact bengr, 2014-10-28 22:47:49]

bengr:
  components/data_reduction_proxy/core/browser/data_reduction_proxy_prefs.cc
 
components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics_prefs.cc
 
components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics_prefs.h
 
components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics_prefs_unittest.cc
  components/data_reduction_proxy/core/common/data_reduction_proxy_pref_names.cc
  components/data_reduction_proxy/core/common/data_reduction_proxy_pref_names.h
mmenke:
  chrome/browser/profiles/profile_io_data.cc

[rpetterson, 2014-10-28 22:52:24]

rlp@chromium.org changed reviewers:
+ rlp@chromium.org

[rpetterson, 2014-10-28 22:52:25]

profiles lgtm

[Not at Google. Contact bengr, 2014-10-28 22:57:09]

kundaji@chromium.org changed reviewers:
- mmenke@chromium.org

[Not at Google. Contact bengr, 2014-10-28 23:59:15]

The CQ bit was checked by kundaji@chromium.org

[commit-bot: I haz the power, 2014-10-28 23:59:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/644883006/60001

[commit-bot: I haz the power, 2014-10-29 00:56:18]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2014-10-29 00:57:05]

Patchset 4 (id:??) landed as
https://crrev.com/5e7bd1206f1e6bfd1adb45bcc823d457bdad8ae2
Cr-Commit-Position: refs/heads/master@{#301752}