Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 644873003: Revert of Revert of Re-enabling fixed WebRTC getusermedia tests. (Closed)

Created:
6 years, 2 months ago by phoglund_chromium
Modified:
6 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of Re-enabling fixed WebRTC getusermedia tests. (patchset #1 id:1 of https://codereview.chromium.org/630143002/) Reason for revert: Should be fixed by https://codereview.chromium.org/638423002/ and https://codereview.chromium.org/640253002. Original issue's description: > Revert of Re-enabling fixed WebRTC getusermedia tests. (patchset #1 id:1 of https://codereview.chromium.org/623733002/) > > Reason for revert: > still flaky, see bug > > Original issue's description: > > Re-enabling fixed WebRTC getusermedia tests. > > > > BUG=417756 > > > > Committed: https://crrev.com/9fa6d13fdbac6c82917c23c9b63b4f3cb7b7593e > > Cr-Commit-Position: refs/heads/master@{#298205} > > TBR=perkj@chromium.org,kjellander@chromium.org,phoglund@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=417756 > > Committed: https://crrev.com/290d2cfa5187ac1f2c87fde4c6dd6f27dad0c93a > Cr-Commit-Position: refs/heads/master@{#298262} TBR=perkj@chromium.org,kjellander@chromium.org,jam@chromium.org NOTREECHECKS=true NOTRY=true BUG=417756 Committed: https://crrev.com/9a09162adb3d7c73cca55c40e5d1aa5c26d005fa Cr-Commit-Position: refs/heads/master@{#299078}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -39 lines) Patch
M content/browser/media/webrtc_getusermedia_browsertest.cc View 4 chunks +8 lines, -39 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
phoglund_chromium
Created Revert of Revert of Re-enabling fixed WebRTC getusermedia tests.
6 years, 2 months ago (2014-10-10 08:49:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/644873003/1
6 years, 2 months ago (2014-10-10 08:50:45 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-10 08:51:19 UTC) #3
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 08:52:13 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9a09162adb3d7c73cca55c40e5d1aa5c26d005fa
Cr-Commit-Position: refs/heads/master@{#299078}

Powered by Google App Engine
This is Rietveld 408576698