Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 644863002: Introduce OpenURL to AppListControllerDelegate. (Closed)

Created:
6 years, 2 months ago by Jun Mukai
Modified:
6 years, 2 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, sadrul, ben+ash_chromium.org, kalyank, oshima
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Introduce OpenURL to AppListControllerDelegate. This does not change the current behavior, it simply opens a tab by using chrome::Navigate(). However https://codereview.chromium.org/640103002/ will introduces app-list search to Athena, then the direct use of chrome::Navigate() is problematic. Athena will handle this method. BUG=380875 R=xiyuan@chromium.org TEST=no functional changes Committed: https://crrev.com/b9a19ebab95668d4747e2161e779f027ee3da068 Cr-Commit-Position: refs/heads/master@{#299049}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+237 lines, -111 lines) Patch
M chrome/browser/ui/app_list/app_list_controller_delegate.h View 1 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_controller_delegate_impl.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_controller_delegate_impl.cc View 1 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/extension_app_model_builder_unittest.cc View 1 4 chunks +3 lines, -37 lines 0 comments Download
M chrome/browser/ui/app_list/search/omnibox_provider.h View 3 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/omnibox_provider.cc View 6 chunks +14 lines, -10 lines 0 comments Download
M chrome/browser/ui/app_list/search/people/people_provider.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/people/people_provider.cc View 2 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/ui/app_list/search/people/people_provider_browsertest.cc View 1 3 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/people/people_result.h View 3 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/people/people_result.cc View 4 chunks +13 lines, -10 lines 0 comments Download
M chrome/browser/ui/app_list/search/search_controller_factory.cc View 1 chunk +12 lines, -8 lines 0 comments Download
M chrome/browser/ui/app_list/search/search_webstore_result.h View 3 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/search_webstore_result.cc View 3 chunks +12 lines, -9 lines 0 comments Download
M chrome/browser/ui/app_list/search/webstore/webstore_provider.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/webstore/webstore_result.cc View 2 chunks +4 lines, -6 lines 0 comments Download
A + chrome/browser/ui/app_list/test/test_app_list_controller_delegate.h View 1 2 chunks +18 lines, -19 lines 0 comments Download
A chrome/browser/ui/app_list/test/test_app_list_controller_delegate.cc View 1 1 chunk +94 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/app_list/app_list_controller_ash.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/app_list/app_list_controller_ash.cc View 1 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Jun Mukai
6 years, 2 months ago (2014-10-09 23:23:57 UTC) #1
xiyuan
lgtm
6 years, 2 months ago (2014-10-09 23:27:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/644863002/1
6 years, 2 months ago (2014-10-10 00:17:46 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/77538)
6 years, 2 months ago (2014-10-10 00:55:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/644863002/380001
6 years, 2 months ago (2014-10-10 02:03:20 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:380001)
6 years, 2 months ago (2014-10-10 02:51:24 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 02:51:59 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b9a19ebab95668d4747e2161e779f027ee3da068
Cr-Commit-Position: refs/heads/master@{#299049}

Powered by Google App Engine
This is Rietveld 408576698