Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 644833002: c++11: Allow type aliases. (Closed)

Created:
6 years, 2 months ago by davidben
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

c++11: Allow type aliases. BUG=none Committed: https://crrev.com/79aaddd7d044b4d71f7e4330201d737d4c801ab8 Cr-Commit-Position: refs/heads/master@{#299018}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M styleguide/c++/c++11.html View 2 chunks +8 lines, -8 lines 2 comments Download

Messages

Total messages: 10 (3 generated)
davidben
Wasn't sure what recommendation to put in the last column. The thread mentioned something about ...
6 years, 2 months ago (2014-10-09 21:58:40 UTC) #2
jamesr
That seems fine. lgtm
6 years, 2 months ago (2014-10-09 22:02:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/644833002/1
6 years, 2 months ago (2014-10-09 22:05:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-10 00:15:52 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/79aaddd7d044b4d71f7e4330201d737d4c801ab8 Cr-Commit-Position: refs/heads/master@{#299018}
6 years, 2 months ago (2014-10-10 00:17:00 UTC) #7
Avi (use Gerrit)
https://codereview.chromium.org/644833002/diff/1/styleguide/c++/c++11.html File styleguide/c++/c++11.html (right): https://codereview.chromium.org/644833002/diff/1/styleguide/c++/c++11.html#newcode166 styleguide/c++/c++11.html:166: Can you do a follow up patch to put ...
6 years, 2 months ago (2014-10-10 13:30:45 UTC) #9
davidben
6 years, 2 months ago (2014-10-10 16:28:33 UTC) #10
Message was sent while issue was closed.
https://codereview.chromium.org/644833002/diff/1/styleguide/c++/c++11.html
File styleguide/c++/c++11.html (right):

https://codereview.chromium.org/644833002/diff/1/styleguide/c++/c++11.html#ne...
styleguide/c++/c++11.html:166: 
On 2014/10/10 13:30:45, Avi wrote:
> Can you do a follow up patch to put this table row in at the position that
> causes it to match the existing alphabetical order?

Whoops. Somehow I didn't notice that. Done:

https://codereview.chromium.org/647773002/

Powered by Google App Engine
This is Rietveld 408576698