Issue 644823003: Revert of Refactor GrLayerHoister::FindLayersToHoist to prep for adding clip to cache key

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 644823003: Revert of Refactor GrLayerHoister::FindLayersToHoist to prep for adding clip to cache key (Closed)

Created:
6 years, 2 months ago by robertphillips

Modified:
6 years, 2 months ago

Reviewers:
jvanverth1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Revert of Refactor GrLayerHoister::FindLayersToHoist to prep for adding clip to cache key (patchset #1 id:1 of https://codereview.chromium.org/640373002/) Reason for revert: Failing unit tests Original issue's description: > Refactor GrLayerHoister::FindLayersToHoist to prep for adding clip to cache key > > NOTRY=true > > Committed: https://skia.googlesource.com/skia/+/27415b71bd529456165945e19b5b7efbebf6fb51 TBR=jvanverth@google.com NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/00878a1f36a28082fe2370e9f05ea931c7d5fed4

Created: 6 years, 2 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -63 lines)			Patch
	M	src/gpu/GrLayerHoister.cpp	View		5 chunks	+67 lines, -63 lines	0 comments	Download

Total messages: 3 (0 generated)

robertphillips

Created Revert of Refactor GrLayerHoister::FindLayersToHoist to prep for adding clip to cache key

6 years, 2 months ago (2014-10-09 19:46:26 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/644823003/1

6 years, 2 months ago (2014-10-09 19:46:37 UTC) #2

commit-bot: I haz the power

6 years, 2 months ago (2014-10-09 19:47:16 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 00878a1f36a28082fe2370e9f05ea931c7d5fed4