Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1027)

Issue 644793002: Renames window_manager.mojom to window_manager2.mojom (Closed)

Created:
6 years, 2 months ago by sky
Modified:
6 years, 2 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Renames window_manager.mojom to window_manager2.mojom We'll come up with better names later on. BUG=none TEST=none R=ben@chromium.org Committed: https://crrev.com/060ec9669e74a704618fede00df445c4bbf8395e Cr-Commit-Position: refs/heads/master@{#299050}

Patch Set 1 #

Patch Set 2 : fix gn #

Patch Set 3 : really fix gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -63 lines) Patch
M mojo/examples/bitmap_uploader/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/cpp/view_manager/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.h View 4 chunks +4 lines, -4 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
D mojo/services/public/interfaces/window_manager/BUILD.gn View 1 chunk +0 lines, -12 lines 0 comments Download
D mojo/services/public/interfaces/window_manager/window_manager.mojom View 1 chunk +0 lines, -28 lines 0 comments Download
A + mojo/services/public/interfaces/window_manager2/BUILD.gn View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/services/public/interfaces/window_manager2/window_manager2.mojom View 1 chunk +7 lines, -4 lines 0 comments Download
M mojo/services/public/mojo_services_public.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/window_manager/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/services/window_manager/window_manager_api_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/services/window_manager/window_manager_service_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
sky
6 years, 2 months ago (2014-10-09 18:02:22 UTC) #1
Ben Goodger (Google)
lgtm
6 years, 2 months ago (2014-10-09 18:09:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/644793002/1
6 years, 2 months ago (2014-10-10 00:07:13 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/23373) linux_chromium_gn_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/6763) linux_chromium_gn_rel ...
6 years, 2 months ago (2014-10-10 00:19:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/644793002/350001
6 years, 2 months ago (2014-10-10 02:12:13 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:350001)
6 years, 2 months ago (2014-10-10 02:57:19 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 02:58:08 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/060ec9669e74a704618fede00df445c4bbf8395e
Cr-Commit-Position: refs/heads/master@{#299050}

Powered by Google App Engine
This is Rietveld 408576698