Replace OVERRIDE with its C++11 counterparts in src/chrome_elf

Replace OVERRIDE with its C++11 counterparts in src/chrome_elf

This step is a complete search for OVERRIDE to
replace it with its lowercase versions.

BUG=417463
Committed: https://crrev.com/0c5b0e52b39e2481d5dfd7a8472daf938b063e69
Cr-Commit-Position: refs/heads/master@{#299241}

[RAGHURAM, 2014-10-10 08:27:34]

r.nagaraj@samsung.com changed reviewers:
+ ben@chromium.org, caitkp@chromium.org, robertshield@chromium.org

[RAGHURAM, 2014-10-10 08:27:35]

Please Review.

Thanks & Regards

[Cait (Slow), 2014-10-10 14:29:25]

lgtm

[RAGHURAM, 2014-10-11 07:19:34]

The CQ bit was checked by r.nagaraj@samsung.com

[commit-bot: I haz the power, 2014-10-11 07:20:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/644783004/1

[commit-bot: I haz the power, 2014-10-11 08:19:46]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-10-11 08:20:33]

Patchset 1 (id:??) landed as
https://crrev.com/0c5b0e52b39e2481d5dfd7a8472daf938b063e69
Cr-Commit-Position: refs/heads/master@{#299241}

[grt (UTC plus 2), 2014-10-16 01:52:21]

grt@chromium.org changed reviewers:
+ grt@chromium.org

[grt (UTC plus 2), 2014-10-16 01:52:21]

https://codereview.chromium.org/644783004/diff/1/chrome_elf/chrome_elf_util_u...
File chrome_elf/chrome_elf_util_unittest.cc (right):

https://codereview.chromium.org/644783004/diff/1/chrome_elf/chrome_elf_util_u...
chrome_elf/chrome_elf_util_unittest.cc:60: virtual void SetUp() override {
the style guide states: "use exactly one of override, final, or virtual when
declaring an override," so this mechanical replacement of OVERRIDE with override
is contrary to style. please remove "virtual" when you change OVERRIDE to
override.

[Avi (use Gerrit), 2014-10-16 01:54:38]

On 2014/10/16 01:52:21, grt wrote:
>
https://codereview.chromium.org/644783004/diff/1/chrome_elf/chrome_elf_util_u...
> File chrome_elf/chrome_elf_util_unittest.cc (right):
> 
>
https://codereview.chromium.org/644783004/diff/1/chrome_elf/chrome_elf_util_u...
> chrome_elf/chrome_elf_util_unittest.cc:60: virtual void SetUp() override {
> the style guide states: "use exactly one of override, final, or virtual when
> declaring an override," so this mechanical replacement of OVERRIDE with
override
> is contrary to style. please remove "virtual" when you change OVERRIDE to
> override.

Did we update the Clang plugin to allow that?

[grt (UTC plus 2), 2014-10-16 03:04:27]

On 2014/10/16 01:54:38, Avi wrote:
> On 2014/10/16 01:52:21, grt wrote:
> >
>
https://codereview.chromium.org/644783004/diff/1/chrome_elf/chrome_elf_util_u...
> > File chrome_elf/chrome_elf_util_unittest.cc (right):
> > 
> >
>
https://codereview.chromium.org/644783004/diff/1/chrome_elf/chrome_elf_util_u...
> > chrome_elf/chrome_elf_util_unittest.cc:60: virtual void SetUp() override {
> > the style guide states: "use exactly one of override, final, or virtual when
> > declaring an override," so this mechanical replacement of OVERRIDE with
> override
> > is contrary to style. please remove "virtual" when you change OVERRIDE to
> > override.
> 
> Did we update the Clang plugin to allow that?

I had thought so based on: http://crrev.com/297129, but perhaps I'm wrong. Is
there something else that needs to be done for the update to take effect?

[robertshield, 2014-10-16 03:28:27]

My understanding was that we allowed both until Clang gets fixed as per
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/EW0wSDQQK8I

The commit you mentioned predates the thread but I haven't seen any
announcement about moving to be consistent with the style guide on this
point yet.

On Wed, Oct 15, 2014 at 11:04 PM, <grt@chromium.org> wrote:

> On 2014/10/16 01:54:38, Avi wrote:
>
>> On 2014/10/16 01:52:21, grt wrote:
>> >
>>
>
> https://codereview.chromium.org/644783004/diff/1/chrome_
> elf/chrome_elf_util_unittest.cc
>
>> > File chrome_elf/chrome_elf_util_unittest.cc (right):
>> >
>> >
>>
>
> https://codereview.chromium.org/644783004/diff/1/chrome_
> elf/chrome_elf_util_unittest.cc#newcode60
>
>> > chrome_elf/chrome_elf_util_unittest.cc:60: virtual void SetUp()
>> override {
>> > the style guide states: "use exactly one of override, final, or virtual
>> when
>> > declaring an override," so this mechanical replacement of OVERRIDE with
>> override
>> > is contrary to style. please remove "virtual" when you change OVERRIDE
>> to
>> > override.
>>
>
>  Did we update the Clang plugin to allow that?
>>
>
> I had thought so based on: http://crrev.com/297129, but perhaps I'm
> wrong. Is
> there something else that needs to be done for the update to take effect?
>
> https://codereview.chromium.org/644783004/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[grt (UTC plus 2), 2014-10-16 13:26:53]

On 2014/10/16 03:28:27, robertshield wrote:
> My understanding was that we allowed both until Clang gets fixed as per
>
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/EW0wSDQQK8I
> 
> The commit you mentioned predates the thread but I haven't seen any
> announcement about moving to be consistent with the style guide on this
> point yet.

Oops, my bad. Carry on.