Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 644783003: [Android] Properly validate potentially null InputDevice (Closed)

Created:
6 years, 2 months ago by jdduke (slow)
Modified:
6 years, 2 months ago
Reviewers:
Feng Qian
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Android] Properly validate potentially null InputDevice As InputDevice.getDevice() makes no guarantees that the returned device will be non-null, always validate the return value before using in a meaningful way as a Gamepad device. BUG=421168 Committed: https://crrev.com/55f9a7718acb7e0e44d61d6ea55a91179d774ce0 Cr-Commit-Position: refs/heads/master@{#299016}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/input/GamepadList.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jdduke (slow)
feng@: PTAL, thanks.
6 years, 2 months ago (2014-10-09 22:14:48 UTC) #2
Feng Qian
lgtm
6 years, 2 months ago (2014-10-09 22:26:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/644783003/1
6 years, 2 months ago (2014-10-09 22:42:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-10 00:12:05 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 00:12:52 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/55f9a7718acb7e0e44d61d6ea55a91179d774ce0
Cr-Commit-Position: refs/heads/master@{#299016}

Powered by Google App Engine
This is Rietveld 408576698