Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 644773002: mojo: Add RunLoop::Current() and refactor unit tests. (Closed)

Created:
6 years, 2 months ago by qsr
Modified:
6 years, 2 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

mojo: Add RunLoop::Current() and refactor unit tests. R=sdefresne@chromium.org Committed: https://crrev.com/f49625ca96cba23ed3113a625a77ba4b2ac00679 Cr-Commit-Position: refs/heads/master@{#299100}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Follow review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -48 lines) Patch
M mojo/public/python/mojo/c_environment.pxd View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/python/mojo/system.pyx View 1 2 chunks +23 lines, -1 line 0 comments Download
M mojo/python/tests/async_wait_unittest.py View 2 chunks +4 lines, -6 lines 0 comments Download
M mojo/python/tests/messaging_unittest.py View 5 chunks +8 lines, -9 lines 0 comments Download
A mojo/python/tests/mojo_unittest.py View 1 chunk +19 lines, -0 lines 0 comments Download
M mojo/python/tests/runloop_unittest.py View 2 chunks +13 lines, -14 lines 0 comments Download
M mojo/python/tests/system_unittest.py View 3 chunks +3 lines, -18 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
qsr
6 years, 2 months ago (2014-10-09 16:34:51 UTC) #1
sdefresne
lgtm https://codereview.chromium.org/644773002/diff/1/mojo/public/python/mojo/system.pyx File mojo/public/python/mojo/system.pyx (right): https://codereview.chromium.org/644773002/diff/1/mojo/public/python/mojo/system.pyx#newcode717 mojo/public/python/mojo/system.pyx:717: _RUN_LOOPS = threading.local() IIUC, _RUN_LOOPS is used to ...
6 years, 2 months ago (2014-10-10 12:29:44 UTC) #2
qsr
https://codereview.chromium.org/644773002/diff/1/mojo/public/python/mojo/system.pyx File mojo/public/python/mojo/system.pyx (right): https://codereview.chromium.org/644773002/diff/1/mojo/public/python/mojo/system.pyx#newcode717 mojo/public/python/mojo/system.pyx:717: _RUN_LOOPS = threading.local() On 2014/10/10 12:29:44, sdefresne wrote: > ...
6 years, 2 months ago (2014-10-10 12:34:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/644773002/180001
6 years, 2 months ago (2014-10-10 12:35:00 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:180001)
6 years, 2 months ago (2014-10-10 13:15:32 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 13:16:07 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/f49625ca96cba23ed3113a625a77ba4b2ac00679
Cr-Commit-Position: refs/heads/master@{#299100}

Powered by Google App Engine
This is Rietveld 408576698