athena/content/web_activity.cc - Issue 644723003: Athena WebActivity returns page title when it's set.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: athena/content/web_activity.cc

Issue 644723003: Athena WebActivity returns page title when it's set. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: athena/content/web_activity.cc

diff --git a/athena/content/web_activity.cc b/athena/content/web_activity.cc

index be9ad2f705132dc3f235fdd17f141f81a0a68d2e..a2affe040f6b6a1f0a34b708811f99ac785c49ea 100644

--- a/athena/content/web_activity.cc

+++ b/athena/content/web_activity.cc

@@ -530,6 +530,9 @@ SkColor WebActivity::GetRepresentativeColor() const {

base::string16 WebActivity::GetTitle() const {

if (!title_.empty())

return title_;

+ const base::string16& title = web_view_->GetWebContents()->GetTitle();

+ if (!title.empty())

+ return title;

return base::UTF8ToUTF16(web_view_->GetWebContents()->GetVisibleURL().host());

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »