Source/core/rendering/RenderLayer.cpp - Issue 644713004: Further cleanup in FilterEffectRenderer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderLayer.cpp

Issue 644713004: Further cleanup in FilterEffectRenderer. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Remove inverseScale() per review. Remove useless #includes. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/RenderLayer.cpp

diff --git a/Source/core/rendering/RenderLayer.cpp b/Source/core/rendering/RenderLayer.cpp

index 719dcefebe6bcf23d038fe433ca6d52844b70ae0..ddd4c8d9fa73f6c329d4bb5824a4112540737adc 100644

--- a/Source/core/rendering/RenderLayer.cpp

+++ b/Source/core/rendering/RenderLayer.cpp

@@ -2714,9 +2714,7 @@ FilterOperations RenderLayer::computeFilterOperations(const RenderStyle* style)

continue;

ReferenceFilterOperation* referenceOperation = toReferenceFilterOperation(filterOperation);

// FIXME: Cache the ReferenceFilter if it didn't change.

- RefPtr<ReferenceFilter> referenceFilter = ReferenceFilter::create();

- float zoom = style->effectiveZoom();

- referenceFilter->setAbsoluteTransform(AffineTransform().scale(zoom, zoom));

+ RefPtr<ReferenceFilter> referenceFilter = ReferenceFilter::create(style->effectiveZoom());

referenceFilter->setLastEffect(ReferenceFilterBuilder::build(referenceFilter.get(), renderer(), referenceFilter->sourceGraphic(),

referenceOperation));

referenceOperation->setFilter(referenceFilter.release());