Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: build/common.gypi

Issue 644683004: android_webview: force clang for host targets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 132fd7ce33a9f05a45ba714964f916d205ef11b7..e2cc9a66b1ae8c1c57b2ce8771a7610baa74960a 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -5579,6 +5579,21 @@
],
},
}],
+ # In the android webview build, force host targets to be compiled with clang
+ # as the hermetic host gcc is very old on some platforms. This is already
+ # the default on the current development version of AOSP but we force it
+ # here in case we need to compile against an older release version.
+ ['android_webview_build==1', {
Primiano Tucci (use gerrit) 2014/10/09 14:18:12 Shouldn't this be android_webview_build==1 and hos
+ 'target_defaults': {
+ 'target_conditions': [
+ ['_toolset=="host"', {
+ 'aosp_build_settings': {
+ 'LOCAL_CLANG': 'true',
+ },
+ }],
+ ],
+ },
+ }],
# We need a special case to handle the android webview build on mac because
# the host gcc there doesn't accept this flag, but the target gcc may
# require it.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698