 Chromium Code Reviews
 Chromium Code Reviews Issue 644683004:
  android_webview: force clang for host targets.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 644683004:
  android_webview: force clang for host targets.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: build/common.gypi | 
| diff --git a/build/common.gypi b/build/common.gypi | 
| index 132fd7ce33a9f05a45ba714964f916d205ef11b7..e2cc9a66b1ae8c1c57b2ce8771a7610baa74960a 100644 | 
| --- a/build/common.gypi | 
| +++ b/build/common.gypi | 
| @@ -5579,6 +5579,21 @@ | 
| ], | 
| }, | 
| }], | 
| + # In the android webview build, force host targets to be compiled with clang | 
| + # as the hermetic host gcc is very old on some platforms. This is already | 
| + # the default on the current development version of AOSP but we force it | 
| + # here in case we need to compile against an older release version. | 
| + ['android_webview_build==1', { | 
| 
Primiano Tucci (use gerrit)
2014/10/09 14:18:12
Shouldn't this be
android_webview_build==1 and hos
 | 
| + 'target_defaults': { | 
| + 'target_conditions': [ | 
| + ['_toolset=="host"', { | 
| + 'aosp_build_settings': { | 
| + 'LOCAL_CLANG': 'true', | 
| + }, | 
| + }], | 
| + ], | 
| + }, | 
| + }], | 
| # We need a special case to handle the android webview build on mac because | 
| # the host gcc there doesn't accept this flag, but the target gcc may | 
| # require it. |