Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 644663004: Use C++11 features in core/workers. (Closed)

Created:
6 years, 2 months ago by babu
Modified:
6 years, 2 months ago
Reviewers:
Mike West, Mikhail
CC:
blink-reviews, kinuko+worker_chromium.org, horo+watch_chromium.org, falken
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Use C++11 features in core/workers. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184262

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -33 lines) Patch
M Source/core/workers/Worker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/WorkerConsole.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/WorkerEventQueue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/WorkerEventQueue.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/workers/WorkerGlobalScope.cpp View 2 chunks +6 lines, -8 lines 0 comments Download
M Source/core/workers/WorkerInspectorProxy.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/workers/WorkerMessagingProxy.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/WorkerMessagingProxy.cpp View 2 chunks +5 lines, -6 lines 0 comments Download
M Source/core/workers/WorkerScriptLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/WorkerThread.cpp View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
babu
6 years, 2 months ago (2014-10-22 20:41:26 UTC) #2
Mikhail
lgtm
6 years, 2 months ago (2014-10-23 07:47:53 UTC) #3
Mike West
LGTM 2.
6 years, 2 months ago (2014-10-23 07:49:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/644663004/1
6 years, 2 months ago (2014-10-23 07:58:30 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/33230)
6 years, 2 months ago (2014-10-23 10:07:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/644663004/1
6 years, 2 months ago (2014-10-23 10:53:15 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 12:44:38 UTC) #11
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 184262

Powered by Google App Engine
This is Rietveld 408576698