Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 644623002: skia: Remove include of record.gypi. (Closed)

Created:
6 years, 2 months ago by tfarina
Modified:
6 years, 2 months ago
Reviewers:
mtklein, rmistry
CC:
chromium-reviews, reed1, rmistry
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

skia: Remove include of record.gypi. It is empty in the skia repo and there is TODO to update Chromium and remove it. BUG=None TEST=None R=rmistry@google.com Committed: https://crrev.com/b2a47705daee8815669894e011e1777faf5012e1 Cr-Commit-Position: refs/heads/master@{#298924}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M skia/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
M skia/skia_library.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
tfarina
Skia CL is here -> https://codereview.chromium.org/643543002/ ptal.
6 years, 2 months ago (2014-10-09 03:22:52 UTC) #1
rmistry
Made Mike the reviewer since he added the original TODO.
6 years, 2 months ago (2014-10-09 11:14:28 UTC) #3
mtklein
lgtm
6 years, 2 months ago (2014-10-09 12:51:32 UTC) #4
tfarina
On Thu, Oct 9, 2014 at 9:51 AM, <mtklein@google.com> wrote: > lgtm > > Thanks. ...
6 years, 2 months ago (2014-10-09 15:43:01 UTC) #5
rmistry
LGTM
6 years, 2 months ago (2014-10-09 16:16:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/644623002/1
6 years, 2 months ago (2014-10-09 17:06:51 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-09 17:25:54 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 17:26:43 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b2a47705daee8815669894e011e1777faf5012e1
Cr-Commit-Position: refs/heads/master@{#298924}

Powered by Google App Engine
This is Rietveld 408576698