Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Issue 644613002: Groom user manager's code. (Closed)

Created:
6 years, 2 months ago by Jun Mukai
Modified:
6 years, 2 months ago
Reviewers:
Nikita (slow), oshima
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Groom user manager's code. - Adds missing files in BUILD.gn - path/to/grit/... would be more preferable than grit/... - remove unnecessary consts BUG=None R=nkostylev@chromium.org TBR=oshima@chromium.org TEST=manually Committed: https://crrev.com/9fa7761f99e2a1e9605cecd45bff5bf48b5f6823 Cr-Commit-Position: refs/heads/master@{#299023}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M components/user_manager/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download
M components/user_manager/DEPS View 1 chunk +2 lines, -2 lines 0 comments Download
M components/user_manager/user_image/default_user_images.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/user_manager/user_manager_base.h View 1 chunk +1 line, -1 line 0 comments Download
M components/user_manager/user_manager_base.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
Jun Mukai
6 years, 2 months ago (2014-10-09 02:32:43 UTC) #1
Nikita (slow)
lgtm
6 years, 2 months ago (2014-10-09 11:02:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/644613002/1
6 years, 2 months ago (2014-10-09 19:03:29 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/16721)
6 years, 2 months ago (2014-10-09 19:13:36 UTC) #6
Jun Mukai
TBR=oshima for tiny DEPS change
6 years, 2 months ago (2014-10-09 23:36:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/644613002/1
6 years, 2 months ago (2014-10-09 23:38:56 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-10 00:23:35 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 00:24:38 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9fa7761f99e2a1e9605cecd45bff5bf48b5f6823
Cr-Commit-Position: refs/heads/master@{#299023}

Powered by Google App Engine
This is Rietveld 408576698