Cleanup of component/metrics for GN.

Cleanup of component/metrics for GN.

- Adds missing rules of BUILD.gn
- removes unnecessary const which causes warning for some compiler
  flag set on GN.

BUG=None
R=mpearson@chromium.org, cmasone@chromium.org
TEST=manually

Committed: https://crrev.com/2c5ea4d8d3f8887e1c581c9fc9c8b8bbc61d74e1
Cr-Commit-Position: refs/heads/master@{#299012}

[Chris Masone, 2014-10-09 02:32:09]

lgtm

[Mark P, 2014-10-09 16:39:10]

components/metrics/serialization/... lgtm

I don't know anything about the :serialization rule.  Hopefully your other
reviewer has the background to review that change.

--mark

[Jun Mukai, 2014-10-09 19:07:09]

mukai@chromium.org changed reviewers:
+ bsimonnet@chromium.org

[Jun Mukai, 2014-10-09 19:07:56]

It seems this target was added at https://codereview.chromium.org/227873002, by
bsimonnet (reviewed by asvitkine). Cc-ing them.

[bsimonnet, 2014-10-09 19:13:18]

On 2014/10/09 19:07:56, Jun Mukai wrote:
> It seems this target was added at https://codereview.chromium.org/227873002,
by
> bsimonnet (reviewed by asvitkine). Cc-ing them.

lgtm

[Chris Masone, 2014-10-09 19:14:03]

Actually, this is a good point. Bertrand, is this a static library that's
intended to be consumed by CrOS, statically linked into code there? If so, then
the current CL wouldn't work because in GN static_library targets basically just
forward the list of objects they pull in up the dependency chain.

[bsimonnet, 2014-10-09 19:30:19]

On 2014/10/09 19:14:03, Chris Masone wrote:
> Actually, this is a good point. Bertrand, is this a static library that's
> intended to be consumed by CrOS, statically linked into code there? If so,
then
> the current CL wouldn't work because in GN static_library targets basically
just
> forward the list of objects they pull in up the dependency chain.

It is not needed directly by the component. The serialization objects are used
by src/chrome/browser/chromeos/external_metrics.cc. I am not sure
external_metrics will be able to reach serialization objects like this.

Other services on chrome OS (not chrome) do not need to access this.

[Chris Masone, 2014-10-09 19:33:01]

On 2014/10/09 19:30:19, bsimonnet wrote:
> On 2014/10/09 19:14:03, Chris Masone wrote:
> > Actually, this is a good point. Bertrand, is this a static library that's
> > intended to be consumed by CrOS, statically linked into code there? If so,
> then
> > the current CL wouldn't work because in GN static_library targets basically
> just
> > forward the list of objects they pull in up the dependency chain.
> 
> It is not needed directly by the component. The serialization objects are used
> by src/chrome/browser/chromeos/external_metrics.cc. I am not sure
> external_metrics will be able to reach serialization objects like this.
> 
> Other services on chrome OS (not chrome) do not need to access this.

I'm still somewhat confused, but it sounds like maybe this would more properly
be a source_set, rather than a static_library. Definitely not a "complete"
static library, which was my concern.

[Chris Masone, 2014-10-09 19:39:42]

On 2014/10/09 19:33:01, Chris Masone wrote:
> On 2014/10/09 19:30:19, bsimonnet wrote:
> > On 2014/10/09 19:14:03, Chris Masone wrote:
> > > Actually, this is a good point. Bertrand, is this a static library that's
> > > intended to be consumed by CrOS, statically linked into code there? If so,
> > then
> > > the current CL wouldn't work because in GN static_library targets
basically
> > just
> > > forward the list of objects they pull in up the dependency chain.
> > 
> > It is not needed directly by the component. The serialization objects are
used
> > by src/chrome/browser/chromeos/external_metrics.cc. I am not sure
> > external_metrics will be able to reach serialization objects like this.
> > 
> > Other services on chrome OS (not chrome) do not need to access this.
> 
> I'm still somewhat confused, but it sounds like maybe this would more properly
> be a source_set, rather than a static_library. Definitely not a "complete"
> static library, which was my concern.

Talked to Bertrand offline, and source_set would probably be more correct, but
as-is is fine.

[Jun Mukai, 2014-10-09 20:17:50]

changed to source_set

[Jun Mukai, 2014-10-09 20:17:56]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-10-09 20:19:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/644603002/100001

[commit-bot: I haz the power, 2014-10-09 20:58:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-09 20:58:12]

Try jobs failed on following builders:
  mac_gpu_retina_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_tr...)

[Jun Mukai, 2014-10-09 23:35:29]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-10-09 23:37:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/644603002/100001

[commit-bot: I haz the power, 2014-10-10 00:00:13]

Committed patchset #2 (id:100001)

[commit-bot: I haz the power, 2014-10-10 00:01:04]

Patchset 2 (id:??) landed as
https://crrev.com/2c5ea4d8d3f8887e1c581c9fc9c8b8bbc61d74e1
Cr-Commit-Position: refs/heads/master@{#299012}