Issue 644563002: Oilpan: Flush a HeapDoesNotContainCache before calling checkAndMarkPointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 644563002: Oilpan: Flush a HeapDoesNotContainCache before calling checkAndMarkPointer (Closed)

Created:
6 years, 2 months ago by haraken

Modified:
6 years, 2 months ago

Reviewers:
oilpan-reviews, zerny-chromium, zerny-google

CC:
blink-reviews, haraken, kouhei+heap_chromium.org, Mads Ager (chromium), mkwst+moarreviews_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Oilpan: Flush a HeapDoesNotContainCache before calling checkAndMarkPointer This is a speculative fix for issue 420699. We must flush a HeapDoesNotContainCache before calling checkAndMarkPointer. This condition holds in the production system because checkAndMarkPointer is called only during a GC and we flush a HeapDoesNotContainCache before starting the GC (if needed). The only place where the condition doesn't hold is a unittest in HeapTest.cpp. This CL adds code to flush the HeapDoesNotContainCache in the unittest. BUG=420699 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183531