Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1058)

Unified Diff: Source/devtools/front_end/host/InspectorFrontendHost.js

Issue 644493003: DevTools: Remove InspectorFrontendAPIImpl.prototype.loadCompleted() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Removed obsolete code Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/devtools/front_end/main/Main.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/host/InspectorFrontendHost.js
diff --git a/Source/devtools/front_end/host/InspectorFrontendHost.js b/Source/devtools/front_end/host/InspectorFrontendHost.js
index 7379a79f02d4bdbfa88002ae9e75725072ce4689..144b9e5877e558541f554e6bad7e14cba2d95603 100644
--- a/Source/devtools/front_end/host/InspectorFrontendHost.js
+++ b/Source/devtools/front_end/host/InspectorFrontendHost.js
@@ -70,20 +70,20 @@ InspectorFrontendHostAPI.EventDescriptors = [
[InspectorFrontendHostAPI.Events.DeviceCountUpdated, ["count"]],
[InspectorFrontendHostAPI.Events.DevicesUpdated, ["devices"]],
[InspectorFrontendHostAPI.Events.DispatchMessage, ["messageObject"]],
- [InspectorFrontendHostAPI.Events.EnterInspectElementMode, [], true],
+ [InspectorFrontendHostAPI.Events.EnterInspectElementMode, []],
[InspectorFrontendHostAPI.Events.FileSystemsLoaded, ["fileSystems"]],
[InspectorFrontendHostAPI.Events.FileSystemRemoved, ["fileSystemPath"]],
[InspectorFrontendHostAPI.Events.FileSystemAdded, ["errorMessage", "fileSystem"]],
[InspectorFrontendHostAPI.Events.IndexingTotalWorkCalculated, ["requestId", "fileSystemPath", "totalWork"]],
[InspectorFrontendHostAPI.Events.IndexingWorked, ["requestId", "fileSystemPath", "worked"]],
[InspectorFrontendHostAPI.Events.IndexingDone, ["requestId", "fileSystemPath"]],
- [InspectorFrontendHostAPI.Events.KeyEventUnhandled, ["event"], true],
- [InspectorFrontendHostAPI.Events.RevealSourceLine, ["url", "lineNumber", "columnNumber"], true],
+ [InspectorFrontendHostAPI.Events.KeyEventUnhandled, ["event"]],
+ [InspectorFrontendHostAPI.Events.RevealSourceLine, ["url", "lineNumber", "columnNumber"]],
[InspectorFrontendHostAPI.Events.SavedURL, ["url"]],
[InspectorFrontendHostAPI.Events.SearchCompleted, ["requestId", "fileSystemPath", "files"]],
[InspectorFrontendHostAPI.Events.SetToolbarColors, ["backgroundColor", "color"]],
[InspectorFrontendHostAPI.Events.SetUseSoftMenu, ["useSoftMenu"]],
- [InspectorFrontendHostAPI.Events.ShowConsole, [], true]
+ [InspectorFrontendHostAPI.Events.ShowConsole, []]
];
InspectorFrontendHostAPI.prototype = {
@@ -248,7 +248,7 @@ InspectorFrontendHostAPI.prototype = {
/**
* @param {boolean} isDocked
- * @param {!function()} callback
+ * @param {function()} callback
*/
setIsDocked: function(isDocked, callback) { },
@@ -349,7 +349,7 @@ WebInspector.InspectorFrontendHostStub.prototype = {
/**
* @param {boolean} isDocked
- * @param {!function()} callback
+ * @param {function()} callback
*/
setIsDocked: function(isDocked, callback)
{
@@ -641,8 +641,6 @@ var InspectorFrontendHost = window.InspectorFrontendHost || null;
*/
function InspectorFrontendAPIImpl()
{
- this._isLoaded = false;
- this._pendingCommands = [];
this._debugFrontend = !!Runtime.queryParam("debugFrontend");
var descriptors = InspectorFrontendHostAPI.EventDescriptors;
@@ -651,16 +649,6 @@ function InspectorFrontendAPIImpl()
}
InspectorFrontendAPIImpl.prototype = {
- loadCompleted: function()
- {
- this._isLoaded = true;
- for (var i = 0; i < this._pendingCommands.length; ++i)
- this._pendingCommands[i]();
- this._pendingCommands = [];
- if (window.opener)
- window.opener.postMessage(["loadCompleted"], "*");
- },
-
/**
* @param {string} name
* @param {!Array.<string>} signature
@@ -671,48 +659,25 @@ InspectorFrontendAPIImpl.prototype = {
var params = Array.prototype.slice.call(arguments, 3);
if (this._debugFrontend)
- setImmediate(innerDispatch.bind(this));
+ setImmediate(innerDispatch);
else
- innerDispatch.call(this);
+ innerDispatch();
- /**
- * @this {!InspectorFrontendAPIImpl}
- */
function innerDispatch()
{
- if (runOnceLoaded)
- this._runOnceLoaded(dispatchAfterLoad);
- else
- dispatchAfterLoad();
-
- function dispatchAfterLoad()
- {
- // Single argument methods get dispatched with the param.
- if (signature.length < 2) {
- InspectorFrontendHost.events.dispatchEventToListeners(name, params[0]);
- return;
- }
- var data = {};
- for (var i = 0; i < signature.length; ++i)
- data[signature[i]] = params[i];
- InspectorFrontendHost.events.dispatchEventToListeners(name, data);
+ // Single argument methods get dispatched with the param.
+ if (signature.length < 2) {
+ InspectorFrontendHost.events.dispatchEventToListeners(name, params[0]);
+ return;
}
+ var data = {};
+ for (var i = 0; i < signature.length; ++i)
+ data[signature[i]] = params[i];
+ InspectorFrontendHost.events.dispatchEventToListeners(name, data);
}
},
/**
- * @param {function()} command
- */
- _runOnceLoaded: function(command)
- {
- if (this._isLoaded) {
- command();
- return;
- }
- this._pendingCommands.push(command);
- },
-
- /**
* @param {number} id
* @param {?string} error
*/
« no previous file with comments | « no previous file | Source/devtools/front_end/main/Main.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698