DevTools: Remove InspectorFrontendAPIImpl.prototype.loadCompleted()

Source/devtools/front_end/host/InspectorFrontendHost.js

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 52 matching lines @@
 }
 
 InspectorFrontendHostAPI.EventDescriptors = [
     [InspectorFrontendHostAPI.Events.AppendedToURL, ["url"]],
     [InspectorFrontendHostAPI.Events.CanceledSaveURL, ["url"]],
     [InspectorFrontendHostAPI.Events.ContextMenuCleared, []],
     [InspectorFrontendHostAPI.Events.ContextMenuItemSelected, ["id"]],
     [InspectorFrontendHostAPI.Events.DeviceCountUpdated, ["count"]],
     [InspectorFrontendHostAPI.Events.DevicesUpdated, ["devices"]],
     [InspectorFrontendHostAPI.Events.DispatchMessage, ["messageObject"]],
-    [InspectorFrontendHostAPI.Events.EnterInspectElementMode, [], true],
+    [InspectorFrontendHostAPI.Events.EnterInspectElementMode, []],
     [InspectorFrontendHostAPI.Events.FileSystemsLoaded, ["fileSystems"]],
     [InspectorFrontendHostAPI.Events.FileSystemRemoved, ["fileSystemPath"]],
     [InspectorFrontendHostAPI.Events.FileSystemAdded, ["errorMessage", "fileSystem"]],
     [InspectorFrontendHostAPI.Events.IndexingTotalWorkCalculated, ["requestId", "fileSystemPath", "totalWork"]],
     [InspectorFrontendHostAPI.Events.IndexingWorked, ["requestId", "fileSystemPath", "worked"]],
     [InspectorFrontendHostAPI.Events.IndexingDone, ["requestId", "fileSystemPath"]],
-    [InspectorFrontendHostAPI.Events.KeyEventUnhandled, ["event"], true],
-    [InspectorFrontendHostAPI.Events.RevealSourceLine, ["url", "lineNumber", "columnNumber"], true],
+    [InspectorFrontendHostAPI.Events.KeyEventUnhandled, ["event"]],
+    [InspectorFrontendHostAPI.Events.RevealSourceLine, ["url", "lineNumber", "columnNumber"]],
     [InspectorFrontendHostAPI.Events.SavedURL, ["url"]],
     [InspectorFrontendHostAPI.Events.SearchCompleted, ["requestId", "fileSystemPath", "files"]],
     [InspectorFrontendHostAPI.Events.SetToolbarColors, ["backgroundColor", "color"]],
     [InspectorFrontendHostAPI.Events.SetUseSoftMenu, ["useSoftMenu"]],
-    [InspectorFrontendHostAPI.Events.ShowConsole, [], true]
+    [InspectorFrontendHostAPI.Events.ShowConsole, []]
 ];
 
 InspectorFrontendHostAPI.prototype = {
     addFileSystem: function() { },
 
     /**
      * @param {string} url
      * @param {string} content
      */
     append: function(url, content) { },
@@ skipping 144 matching lines @@
     setDevicesUpdatesEnabled: function(enabled) { },
 
     /**
      * @param {string} origin
      * @param {string} script
      */
     setInjectedScriptForOrigin: function(origin, script) { },
 
     /**
      * @param {boolean} isDocked
-     * @param {!function()} callback
+     * @param {function()} callback
      */
     setIsDocked: function(isDocked, callback) { },
 
     /**
      * @param {number} zoom
      */
     setZoomFactor: function(zoom) { },
 
     /**
      * @return {number}
@@ skipping 80 matching lines @@
         this._windowVisible = true;
     },
 
     closeWindow: function()
     {
         this._windowVisible = false;
     },
 
     /**
      * @param {boolean} isDocked
-     * @param {!function()} callback
+     * @param {function()} callback
      */
     setIsDocked: function(isDocked, callback)
     {
     },
 
     /**
      * Requests inspected page to be placed atop of the inspector frontend with specified bounds.
      * @param {{x: number, y: number, width: number, height: number}} bounds
      */
     setInspectedPageBounds: function(bounds)
@@ skipping 271 matching lines @@
 
     // Attach the events object.
     InspectorFrontendHost.events = new WebInspector.Object();
 })();
 
 /**
  * @constructor
  */
 function InspectorFrontendAPIImpl()
 {
-    this._isLoaded = false;
-    this._pendingCommands = [];
     this._debugFrontend = !!Runtime.queryParam("debugFrontend");
 
     var descriptors = InspectorFrontendHostAPI.EventDescriptors;
     for (var i = 0; i < descriptors.length; ++i)
         this[descriptors[i][0]] = this._dispatch.bind(this, descriptors[i][0], descriptors[i][1], descriptors[i][2]);
 }
 
 InspectorFrontendAPIImpl.prototype = {
-    loadCompleted: function()
-    {
-        this._isLoaded = true;
-        for (var i = 0; i < this._pendingCommands.length; ++i)
-            this._pendingCommands[i]();
-        this._pendingCommands = [];
-        if (window.opener)
-            window.opener.postMessage(["loadCompleted"], "*");

[apavlov, 2014/10/09 12:28:07]

What does this do? I've got no clue...

-    },
-
     /**
      * @param {string} name
      * @param {!Array.<string>} signature
      * @param {boolean} runOnceLoaded
      */
     _dispatch: function(name, signature, runOnceLoaded)
     {
         var params = Array.prototype.slice.call(arguments, 3);
 
         if (this._debugFrontend)
-            setImmediate(innerDispatch.bind(this));
+            setImmediate(innerDispatch);
         else
-            innerDispatch.call(this);
+            innerDispatch();
 
-        /**
-         * @this {!InspectorFrontendAPIImpl}
-         */
         function innerDispatch()
         {
-            if (runOnceLoaded)
-                this._runOnceLoaded(dispatchAfterLoad);
-            else
-                dispatchAfterLoad();
-
-            function dispatchAfterLoad()
-            {
-                // Single argument methods get dispatched with the param.
-                if (signature.length < 2) {
-                    InspectorFrontendHost.events.dispatchEventToListeners(name, params[0]);
-                    return;
-                }
-                var data = {};
-                for (var i = 0; i < signature.length; ++i)
-                    data[signature[i]] = params[i];
-                InspectorFrontendHost.events.dispatchEventToListeners(name, data);
+            // Single argument methods get dispatched with the param.
+            if (signature.length < 2) {
+                InspectorFrontendHost.events.dispatchEventToListeners(name, params[0]);
+                return;
             }
+            var data = {};
+            for (var i = 0; i < signature.length; ++i)
+                data[signature[i]] = params[i];
+            InspectorFrontendHost.events.dispatchEventToListeners(name, data);
         }
     },
 
     /**
-     * @param {function()} command
-     */
-    _runOnceLoaded: function(command)
-    {
-        if (this._isLoaded) {
-            command();
-            return;
-        }
-        this._pendingCommands.push(command);
-    },
-
-    /**
      * @param {number} id
      * @param {?string} error
      */
     embedderMessageAck: function(id, error)
     {
         InspectorFrontendHost["embedderMessageAck"](id, error);
     }
 }
 
 var InspectorFrontendAPI = new InspectorFrontendAPIImpl();