DevTools: Remove InspectorFrontendAPIImpl.prototype.loadCompleted()

DevTools: Remove InspectorFrontendAPIImpl.prototype.loadCompleted()

https://crrev.com/6bffde4d87f7a05e5a871cd48366d56b8b83e950 introduces
dispatching of messages on InspectorFrontendAPI post the
IFH.loadCompleted() call only, hence the IFAPI.loadCompleted() call
is no longer required.

R=pfeldman@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183601

[apavlov, 2014-10-09 12:26:51]

Patchset #1 (id:1) has been deleted

[apavlov, 2014-10-09 12:28:07]

https://codereview.chromium.org/644493003/diff/20001/Source/devtools/front_en...
File Source/devtools/front_end/host/InspectorFrontendHost.js (left):

https://codereview.chromium.org/644493003/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/host/InspectorFrontendHost.js:661:
window.opener.postMessage(["loadCompleted"], "*");
What does this do? I've got no clue...

[apavlov, 2014-10-09 14:16:52]

With this change applied, all DevToolsSanityTests are timing out:

[21695:21695:1009/164014:ERROR:CONSOLE(1)] "Uncaught ReferenceError:
WebInspector is not defined", source:  (1)
[21695:21695:1009/164014:ERROR:CONSOLE(1)] "Uncaught ReferenceError:
InspectorFrontendAPI is not defined", source:  (1)
[21695:21695:1009/164014:ERROR:CONSOLE(1)] "Uncaught ReferenceError:
WebInspector is not defined", source:  (1)

Any ideas while I'm investigating?

[apavlov, 2014-10-09 14:45:11]

On 2014/10/09 14:16:52, apavlov wrote:
> With this change applied, all DevToolsSanityTests are timing out:
> 
> [21695:21695:1009/164014:ERROR:CONSOLE(1)] "Uncaught ReferenceError:
> WebInspector is not defined", source:  (1)
> [21695:21695:1009/164014:ERROR:CONSOLE(1)] "Uncaught ReferenceError:
> InspectorFrontendAPI is not defined", source:  (1)
> [21695:21695:1009/164014:ERROR:CONSOLE(1)] "Uncaught ReferenceError:
> WebInspector is not defined", source:  (1)
> 
> Any ideas while I'm investigating?

Ah, sorry for the noise. I had forgotten to gyp_chromium.

[pfeldman, 2014-10-13 09:03:36]

lgtm

https://codereview.chromium.org/644493003/diff/20001/Source/devtools/front_en...
File Source/devtools/front_end/main/Main.js (right):

https://codereview.chromium.org/644493003/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/main/Main.js:256: // FIXME: Is this used at all?
Nuke.

[apavlov, 2014-10-13 09:21:15]

The CQ bit was checked by apavlov@chromium.org

[apavlov, 2014-10-13 09:21:28]

https://codereview.chromium.org/644493003/diff/20001/Source/devtools/front_en...
File Source/devtools/front_end/main/Main.js (right):

https://codereview.chromium.org/644493003/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/main/Main.js:256: // FIXME: Is this used at all?
On 2014/10/13 09:03:36, pfeldman-ooo-until-oct-12 wrote:
> Nuke.

Done.

[commit-bot: I haz the power, 2014-10-13 09:22:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/644493003/60001

[commit-bot: I haz the power, 2014-10-13 11:22:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-13 11:22:36]

Exceeded time limit waiting for builds to trigger.

[apavlov, 2014-10-13 12:16:28]

The CQ bit was checked by apavlov@chromium.org

[commit-bot: I haz the power, 2014-10-13 12:17:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/644493003/60001

[commit-bot: I haz the power, 2014-10-13 12:17:35]

Committed patchset #2 (id:60001) as 183601