Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 644463003: [Cast, Android] Don't hold the wake lock if the video is playing remotely. (Closed)

Created:
6 years, 2 months ago by whywhat
Modified:
6 years, 2 months ago
Reviewers:
qinmin, nasko
CC:
chromium-reviews, creis+watch_chromium.org, posciak+watch_chromium.org, avayvod+watch_chromium.org, nasko+codewatch_chromium.org, jam, mcasas+watch_chromium.org, mkwst+moarreviews-ipc_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Cast, Android] Don't hold the wake lock if the video is playing remotely. Since the video is actually playing on a remote device, there's no need to prevent the screen from fading and locking. BUG=420665 TEST=manual Committed: https://crrev.com/68017be636f8e3446174f9915503fb80345bf54f Cr-Commit-Position: refs/heads/master@{#299137}

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Moved virtual method to .cc file. Fixed unittest #

Patch Set 4 : Fixed player id in the test #

Patch Set 5 : Ignore remote players altogether #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -8 lines) Patch
M content/browser/web_contents/web_contents_impl.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 2 3 4 1 chunk +6 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl_unittest.cc View 1 2 3 5 chunks +18 lines, -3 lines 0 comments Download
M content/common/frame_messages.h View 1 chunk +3 lines, -2 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
whywhat
6 years, 2 months ago (2014-10-08 21:00:22 UTC) #2
nasko
LGTM
6 years, 2 months ago (2014-10-08 23:53:22 UTC) #3
qinmin
what will happen if video is playing locally with wake lock acquired, then casted to ...
6 years, 2 months ago (2014-10-09 01:18:15 UTC) #4
whywhat
On 2014/10/09 01:18:15, qinmin wrote: > what will happen if video is playing locally with ...
6 years, 2 months ago (2014-10-09 09:21:34 UTC) #5
qinmin
lgtm
6 years, 2 months ago (2014-10-10 17:03:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/644463003/330001
6 years, 2 months ago (2014-10-10 17:34:48 UTC) #8
commit-bot: I haz the power
Committed patchset #5 (id:330001)
6 years, 2 months ago (2014-10-10 18:02:55 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 18:03:40 UTC) #10
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/68017be636f8e3446174f9915503fb80345bf54f
Cr-Commit-Position: refs/heads/master@{#299137}

Powered by Google App Engine
This is Rietveld 408576698