runtime/vm/freelist_test.cc - Issue 644453003: Simplify VirtualMemory by removing unused ReserveAligned method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/freelist_test.cc

Issue 644453003: Simplify VirtualMemory by removing unused ReserveAligned method. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/freelist_test.cc

===================================================================

--- runtime/vm/freelist_test.cc (revision 41000)

+++ runtime/vm/freelist_test.cc (working copy)

@@ -120,7 +120,8 @@

const intptr_t kObjectSize = 2 * kWordSize;

uword* objects = new uword[kBlobSize / kObjectSize];

- VirtualMemory* blob = VirtualMemory::ReserveAligned(kBlobSize, 4096);

+ VirtualMemory* blob = VirtualMemory::Reserve(kBlobSize);

+ ASSERT(Utils::IsAligned(blob->start(), 4096));

blob->Commit(/* is_executable = */ false);

blob->Protect(VirtualMemory::kReadWrite);

@@ -162,7 +163,8 @@

objects[i] = static_cast<uword>(NULL);

}

- VirtualMemory* blob = VirtualMemory::ReserveAligned(kBlobSize, 4096);

+ VirtualMemory* blob = VirtualMemory::Reserve(kBlobSize);

+ ASSERT(Utils::IsAligned(blob->start(), 4096));

blob->Commit(/* is_executable = */ false);

blob->Protect(VirtualMemory::kReadWrite);

« no previous file with comments | « no previous file | runtime/vm/pages.cc » ('j') | runtime/vm/virtual_memory.h » ('J')