Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 644443002: ui::PlatformWindowDelegate::OnClosed() isn't called when a ui::X11Window is closed (Closed)

Created:
6 years, 2 months ago by hansmuller
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ui::PlatformWindowDelegate::OnClosed() isn't called when a ui::X11Window is closed This problem manifests itself in simple Mojo apps that use NativeViewportService on X11. When the NativeViewport window is closed, the NativeViewportClient OnDestroyed() method does not run. BUG=421536 Committed: https://crrev.com/b37606e1c2a6703e58a61a978e8e32be72acae0c Cr-Commit-Position: refs/heads/master@{#298926}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ui/platform_window/x11/x11_window.cc View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 10 (2 generated)
hansmuller
There's a complete description of the problem in the bug report - crbug.com/421536 This is ...
6 years, 2 months ago (2014-10-08 19:42:50 UTC) #2
Ben Goodger (Google)
https://codereview.chromium.org/644443002/diff/1/ui/platform_window/x11/x11_window.cc File ui/platform_window/x11/x11_window.cc (right): https://codereview.chromium.org/644443002/diff/1/ui/platform_window/x11/x11_window.cc#newcode59 ui/platform_window/x11/x11_window.cc:59: delegate_->OnClosed(); I'm no Xpert, is there no callback you ...
6 years, 2 months ago (2014-10-08 20:45:40 UTC) #3
hansmuller
On 2014/10/08 20:45:40, Ben Goodger (Google) wrote: > https://codereview.chromium.org/644443002/diff/1/ui/platform_window/x11/x11_window.cc > File ui/platform_window/x11/x11_window.cc (right): > > ...
6 years, 2 months ago (2014-10-08 21:57:45 UTC) #4
Ben Goodger (Google)
lgtm
6 years, 2 months ago (2014-10-09 16:57:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/644443002/1
6 years, 2 months ago (2014-10-09 17:06:53 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-09 17:29:23 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b37606e1c2a6703e58a61a978e8e32be72acae0c Cr-Commit-Position: refs/heads/master@{#298926}
6 years, 2 months ago (2014-10-09 17:30:09 UTC) #9
jwd
6 years, 2 months ago (2014-10-09 21:37:54 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/647573002/ by jwd@chromium.org.

The reason for reverting is: Only cl that seems related to
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Te...
falures..

Powered by Google App Engine
This is Rietveld 408576698