Replace MockStatisticsProvider with FakeStatisticsProvider.

chrome/browser/chromeos/policy/device_status_collector_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/policy/device_status_collector.h"
 
 #include "base/environment.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop.h"
 #include "base/prefs/pref_service.h"
 #include "base/prefs/testing_pref_service.h"
 #include "base/run_loop.h"
 #include "base/threading/sequenced_worker_pool.h"
 #include "chrome/browser/chromeos/login/users/mock_user_manager.h"
 #include "chrome/browser/chromeos/login/users/scoped_user_manager_enabler.h"
 #include "chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h"
 #include "chrome/browser/chromeos/policy/stub_enterprise_install_attributes.h"
 #include "chrome/browser/chromeos/settings/cros_settings.h"
 #include "chrome/browser/chromeos/settings/device_settings_service.h"
 #include "chrome/browser/chromeos/settings/stub_cros_settings_provider.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/test/base/testing_browser_process.h"
 #include "chromeos/dbus/dbus_thread_manager.h"
 #include "chromeos/dbus/shill_device_client.h"
 #include "chromeos/network/network_handler.h"
 #include "chromeos/settings/cros_settings_names.h"
 #include "chromeos/settings/cros_settings_provider.h"
-#include "chromeos/system/mock_statistics_provider.h"
+#include "chromeos/system/fake_statistics_provider.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/geolocation_provider.h"
 #include "content/public/test/test_browser_thread.h"
 #include "content/public/test/test_utils.h"
 #include "policy/proto/device_management_backend.pb.h"
-#include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/cros_system_api/dbus/service_constants.h"
 
-using ::testing::DoAll;
-using ::testing::NotNull;
-using ::testing::Return;
-using ::testing::SetArgPointee;
-using ::testing::_;
 using base::Time;
 using base::TimeDelta;
 
 namespace em = enterprise_management;
 
 namespace {
 
 const int64 kMillisecondsPerDay = Time::kMicrosecondsPerDay / 1000;
 
 scoped_ptr<content::Geoposition> mock_position_to_return_next;
@@ skipping 104 matching lines @@
                           DEVICE_MODE_ENTERPRISE),
       user_manager_(new chromeos::MockUserManager()),
       user_manager_enabler_(user_manager_) {
     // Run this test with a well-known timezone so that Time::LocalMidnight()
     // returns the same values on all machines.
     scoped_ptr<base::Environment> env(base::Environment::Create());
     env->SetVar("TZ", "UTC");
 
     TestingDeviceStatusCollector::RegisterPrefs(prefs_.registry());
 
-    EXPECT_CALL(statistics_provider_, GetMachineStatistic(_, NotNull()))
-        .WillRepeatedly(Return(false));
-
     // Remove the real DeviceSettingsProvider and replace it with a stub.
     cros_settings_ = chromeos::CrosSettings::Get();
     device_settings_provider_ =
         cros_settings_->GetProvider(chromeos::kReportDeviceVersionInfo);
     EXPECT_TRUE(device_settings_provider_ != NULL);
     EXPECT_TRUE(
         cros_settings_->RemoveSettingsProvider(device_settings_provider_));
     cros_settings_->AddSettingsProvider(&stub_settings_provider_);
 
     RestartStatusCollector();
@@ skipping 13 matching lines @@
   virtual void SetUp() override {
     // Disable network interface reporting since it requires additional setup.
     cros_settings_->SetBoolean(chromeos::kReportDeviceNetworkInterfaces, false);
   }
 
   void RestartStatusCollector() {
     policy::DeviceStatusCollector::LocationUpdateRequester callback =
         base::Bind(&MockPositionUpdateRequester);
     status_collector_.reset(
         new TestingDeviceStatusCollector(&prefs_,
-                                         &statistics_provider_,
+                                         &fake_statistics_provider_,
                                          &callback));
   }
 
   void GetStatus() {
     status_.Clear();
     status_collector_->GetDeviceStatus(&status_);
   }
 
   void CheckThatNoLocationIsReported() {
     GetStatus();
@@ skipping 43 matching lines @@
   // Since this is a unit test running in browser_tests we must do additional
   // unit test setup and make a TestingBrowserProcess. Must be first member.
   TestingBrowserProcessInitializer initializer_;
   base::MessageLoopForUI message_loop_;
   content::TestBrowserThread ui_thread_;
   content::TestBrowserThread file_thread_;
   content::TestBrowserThread io_thread_;
 
   ScopedStubEnterpriseInstallAttributes install_attributes_;
   TestingPrefServiceSimple prefs_;
-  chromeos::system::MockStatisticsProvider statistics_provider_;
+  chromeos::system::ScopedFakeStatisticsProvider fake_statistics_provider_;
   chromeos::ScopedTestDeviceSettingsService test_device_settings_service_;
   chromeos::ScopedTestCrosSettings test_cros_settings_;
   chromeos::CrosSettings* cros_settings_;
   chromeos::CrosSettingsProvider* device_settings_provider_;
   chromeos::StubCrosSettingsProvider stub_settings_provider_;
   chromeos::MockUserManager* user_manager_;
   chromeos::ScopedUserManagerEnabler user_manager_enabler_;
   em::DeviceStatusReportRequest status_;
   scoped_ptr<TestingDeviceStatusCollector> status_collector_;
 };
@@ skipping 231 matching lines @@
   // After indicating a successful submit, the submitted status gets cleared,
   // but what got collected meanwhile sticks around.
   status_collector_->Simulate(test_states, 1);
   status_collector_->OnSubmittedSuccessfully();
   GetStatus();
   EXPECT_EQ(ActivePeriodMilliseconds(), GetActiveMilliseconds(status_));
 }
 
 TEST_F(DeviceStatusCollectorTest, DevSwitchBootMode) {
   // Test that boot mode data is reported by default.
-  EXPECT_CALL(statistics_provider_,
-              GetMachineStatistic("devsw_boot", NotNull()))
-      .WillOnce(DoAll(SetArgPointee<1>("0"), Return(true)));
+  fake_statistics_provider_.SetMachineStatistic("devsw_boot", "0");
   GetStatus();
   EXPECT_EQ("Verified", status_.boot_mode());
 
   // Test that boot mode data is not reported if the pref turned off.
   cros_settings_->SetBoolean(chromeos::kReportDeviceBootMode, false);
 
-  EXPECT_CALL(statistics_provider_,
-              GetMachineStatistic("devsw_boot", NotNull()))
-      .WillRepeatedly(DoAll(SetArgPointee<1>("0"), Return(true)));
   GetStatus();
   EXPECT_FALSE(status_.has_boot_mode());
 
   // Turn the pref on, and check that the status is reported iff the
   // statistics provider returns valid data.
   cros_settings_->SetBoolean(chromeos::kReportDeviceBootMode, true);
 
-  EXPECT_CALL(statistics_provider_,
-              GetMachineStatistic("devsw_boot", NotNull()))
-      .WillOnce(DoAll(SetArgPointee<1>("(error)"), Return(true)));
+  fake_statistics_provider_.SetMachineStatistic("devsw_boot", "(error)");
   GetStatus();
   EXPECT_FALSE(status_.has_boot_mode());
 
-  EXPECT_CALL(statistics_provider_,
-              GetMachineStatistic("devsw_boot", NotNull()))
-      .WillOnce(DoAll(SetArgPointee<1>(" "), Return(true)));
+  fake_statistics_provider_.SetMachineStatistic("devsw_boot", " ");
   GetStatus();
   EXPECT_FALSE(status_.has_boot_mode());
 
-  EXPECT_CALL(statistics_provider_,
-              GetMachineStatistic("devsw_boot", NotNull()))
-      .WillOnce(DoAll(SetArgPointee<1>("0"), Return(true)));
+  fake_statistics_provider_.SetMachineStatistic("devsw_boot", "0");
   GetStatus();
   EXPECT_EQ("Verified", status_.boot_mode());
 
-  EXPECT_CALL(statistics_provider_,
-              GetMachineStatistic("devsw_boot", NotNull()))
-      .WillOnce(DoAll(SetArgPointee<1>("1"), Return(true)));
+  fake_statistics_provider_.SetMachineStatistic("devsw_boot", "1");
   GetStatus();
   EXPECT_EQ("Dev", status_.boot_mode());
 }
 
 TEST_F(DeviceStatusCollectorTest, VersionInfo) {
   // Expect the version info to be reported by default.
   GetStatus();
   EXPECT_TRUE(status_.has_browser_version());
   EXPECT_TRUE(status_.has_os_version());
   EXPECT_TRUE(status_.has_firmware_version());
@@ skipping 217 matching lines @@
     }
 
     EXPECT_TRUE(found_match) << "No matching interface for fake device " << i;
     count++;
   }
 
   EXPECT_EQ(count, status_.network_interface_size());
 }
 
 }  // namespace policy