Replace MockStatisticsProvider with FakeStatisticsProvider.

chrome/browser/chromeos/login/oobe_localization_browsertest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/message_loop/message_loop.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/stringprintf.h"
 #include "base/task_runner.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/chromeos/customization_document.h"
 #include "chrome/browser/chromeos/input_method/input_method_util.h"
 #include "chrome/browser/chromeos/login/login_manager_test.h"
 #include "chrome/browser/chromeos/login/login_wizard.h"
 #include "chrome/browser/chromeos/login/test/js_checker.h"
 #include "chrome/browser/chromeos/login/ui/login_display_host_impl.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "chromeos/ime/extension_ime_util.h"
 #include "chromeos/ime/input_method_manager.h"
 #include "chromeos/ime/input_method_whitelist.h"
+#include "chromeos/system/fake_statistics_provider.h"
 #include "chromeos/system/statistics_provider.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/test/browser_test_utils.h"
 #include "content/public/test/test_utils.h"
 
 namespace base {
 class TaskRunner;
 }
 
 namespace chromeos {
 
 namespace {
 
 // OOBE constants.
 const char* kLocaleSelect = "language-select";
 const char* kKeyboardSelect = "keyboard-select";
 
 const char* kUSLayout = "xkb:us::eng";
 
 }
 
-namespace system {
-
-// Custom StatisticsProvider that will return each set of region settings.
-class FakeStatisticsProvider : public StatisticsProvider {
- public:
-  virtual ~FakeStatisticsProvider() {}
-
-  void set_locale(const std::string& locale) {
-    initial_locale_ = locale;
-  }
-
-  void set_keyboard_layout(const std::string& keyboard_layout) {
-    keyboard_layout_ = keyboard_layout;
-  }
-
- private:
-  // StatisticsProvider overrides.
-  virtual void StartLoadingMachineStatistics(
-      const scoped_refptr<base::TaskRunner>& file_task_runner,
-      bool load_oem_manifest) override {
-  }
-
-  // Populates the named machine statistic for initial_locale and
-  // keyboard_layout only.
-  virtual bool GetMachineStatistic(const std::string& name,
-                                   std::string* result) override {
-    if (name == "initial_locale")
-      *result = initial_locale_;
-    else if (name == "keyboard_layout")
-      *result = keyboard_layout_;
-    else
-      return false;
-
-    return true;
-  }
-
-  virtual bool GetMachineFlag(const std::string& name, bool* result) override {
-    return false;
-  }
-
-  virtual void Shutdown() override {
-  }
-
-  std::string initial_locale_;
-  std::string keyboard_layout_;
-};
-
-}  // namespace system
-
 struct LocalizationTestParams {
   const char* initial_locale;
   const char* keyboard_layout;
   const char* expected_locale;
   const char* expected_keyboard_layout;
   const char* expected_keyboard_select_control;
 } const oobe_localization_test_parameters[] = {
       // ------------------ Non-Latin setup
       // For a non-Latin keyboard layout like Russian, we expect to see the US
       // keyboard.
@@ skipping 52 matching lines @@
        "en-AU",
        "xkb:us::eng",
        "xkb:us::eng,[xkb:gb:extd:eng,xkb:gb:dvorak:eng]"},
 };
 
 class OobeLocalizationTest
     : public LoginManagerTest,
       public testing::WithParamInterface<const LocalizationTestParams*> {
  public:
   OobeLocalizationTest();
-  virtual ~OobeLocalizationTest();
 
   // Verifies that the comma-separated |values| corresponds with the first
   // values in |select_id|, optionally checking for an options group label after
   // the first set of options.
   bool VerifyInitialOptions(const char* select_id,
                             const char* values,
                             bool check_separator);
 
   // Verifies that |value| exists in |select_id|.
   bool VerifyOptionExists(const char* select_id, const char* value);
@@ skipping 13 matching lines @@
     chromeos::OobeUI* oobe_ui = host->GetOobeUI();
     if (!oobe_ui)
       return;
     base::RunLoop run_loop;
     const bool oobe_ui_ready = oobe_ui->IsJSReady(run_loop.QuitClosure());
     if (!oobe_ui_ready)
       run_loop.Run();
   }
 
  private:
-  scoped_ptr<system::FakeStatisticsProvider> statistics_provider_;
+  system::ScopedFakeStatisticsProvider fake_statistics_provider_;
   test::JSChecker checker;
 
   DISALLOW_COPY_AND_ASSIGN(OobeLocalizationTest);
 };
 
 OobeLocalizationTest::OobeLocalizationTest() : LoginManagerTest(false) {
-  statistics_provider_.reset(new system::FakeStatisticsProvider());
-  // Set the instance returned by GetInstance() for testing.
-  system::StatisticsProvider::SetTestProvider(statistics_provider_.get());
-
-  statistics_provider_->set_locale(GetParam()->initial_locale);
-  statistics_provider_->set_keyboard_layout(GetParam()->keyboard_layout);
-}
-
-OobeLocalizationTest::~OobeLocalizationTest() {
-  system::StatisticsProvider::SetTestProvider(NULL);
+  fake_statistics_provider_.SetMachineStatistic("initial_locale",
+                                                GetParam()->initial_locale);
+  fake_statistics_provider_.SetMachineStatistic("keyboard_layout",
+                                                GetParam()->keyboard_layout);
 }
 
 bool OobeLocalizationTest::VerifyInitialOptions(const char* select_id,
                                                 const char* values,
                                                 bool check_separator) {
   const std::string expression = base::StringPrintf(
       "(function () {\n"
       "  var select = document.querySelector('#%s');\n"
       "  if (!select)\n"
       "    return false;\n"
@@ skipping 176 matching lines @@
   RunLocalizationTest();
 }
 
 INSTANTIATE_TEST_CASE_P(
     StructSequence,
     OobeLocalizationTest,
     testing::Range(&oobe_localization_test_parameters[0],
                    &oobe_localization_test_parameters[arraysize(
                        oobe_localization_test_parameters)]));
 }  // namespace chromeos