Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 64433003: Revert of untrusted.gyp to fix goma_status=ok error. (Closed)

Created:
7 years, 1 month ago by Yoshisato Yanagisawa
Modified:
7 years, 1 month ago
CC:
native-client-reviews_googlegroups.com
Base URL:
http://src.chromium.org/native_client/trunk/src/native_client/
Visibility:
Public.

Description

Revert r12387: "Enables goma from GYP and GOMA_DIR env." Since r12387 caused following error, let me revert r12387: Updating projects from gyp files... gyp: name 'goma_status' is not defined while evaluating condition 'goma_status!="ok"' in /mnt/scratch0/b_used/build/slave/linux/build/src/components/nacl.gyp gyp: name 'goma_status' is not defined while evaluating condition 'goma_status!="ok"' in /mnt/scratch0/b_used/build/slave/linux/build/src/ppapi/ppapi_untrusted.gyp gyp: name 'goma_status' is not defined while evaluating condition 'goma_status!="ok"' in /mnt/scratch0/b_used/build/slave/linux/build/src/ppapi/tests/extensions/extensions.gyp ... This error is from http://build.chromium.org/p/tryserver.chromium/builders/linux_rel/builds/189929/steps/runhooks/logs/stdio See https://codereview.chromium.org/71693004/ See also issue of r12387: https://codereview.chromium.org/66303010/ NOTRY=true (since trybots have already been run for this change) Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=12396

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -73 lines) Patch
M build/build_nexe.py View 1 5 chunks +8 lines, -34 lines 0 comments Download
M build/common.gypi View 1 3 chunks +0 lines, -8 lines 0 comments Download
M build/untrusted.gypi View 26 chunks +1 line, -31 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Yoshisato Yanagisawa
I seems not send this. This is just revert of untrusted.gypi to fix goma_status=ok issue ...
7 years, 1 month ago (2013-11-15 00:55:45 UTC) #1
Mark Seaborn
It would be cleaner to revert all of r12387 rather than just part of it. ...
7 years, 1 month ago (2013-11-15 18:27:38 UTC) #2
Yoshisato Yanagisawa
On 2013/11/15 18:27:38, Mark Seaborn wrote: > It would be cleaner to revert all of ...
7 years, 1 month ago (2013-11-15 21:50:44 UTC) #3
Yoshisato Yanagisawa
On 2013/11/15 21:50:44, yanagisawa wrote: > On 2013/11/15 18:27:38, Mark Seaborn wrote: > > It ...
7 years, 1 month ago (2013-11-15 21:54:31 UTC) #4
Mark Seaborn
On 2013/11/15 21:50:44, yanagisawa wrote: > On 2013/11/15 18:27:38, Mark Seaborn wrote: > > It ...
7 years, 1 month ago (2013-11-16 00:08:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/yyanagisawa@chromium.org/64433003/550001
7 years, 1 month ago (2013-11-16 01:00:42 UTC) #6
commit-bot: I haz the power
7 years, 1 month ago (2013-11-16 01:00:57 UTC) #7
Message was sent while issue was closed.
Change committed as 12396

Powered by Google App Engine
This is Rietveld 408576698