Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: cc/resources/picture_layer_tiling.h

Issue 644313002: cc: Use reverse spiral iterator in tiling eviction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/resources/picture_layer_tiling.h
diff --git a/cc/resources/picture_layer_tiling.h b/cc/resources/picture_layer_tiling.h
index 3b60edd871964ff57084d2299c7cc1f2c6a98c9e..10ffca7e9d60048dcecc5dcf920f9f4aad396276 100644
--- a/cc/resources/picture_layer_tiling.h
+++ b/cc/resources/picture_layer_tiling.h
@@ -130,8 +130,22 @@ class CC_EXPORT PictureLayerTiling {
TilingEvictionTileIterator& operator++();
private:
- const std::vector<Tile*>* eviction_tiles_;
- size_t current_eviction_tiles_index_;
+ void AdvanceEventually(bool first_run);
+ void AdvanceSoon(bool first_run);
+ void AdvanceNow(bool first_run);
+
+ PictureLayerTiling* tiling_;
+ EvictionCategory eviction_category_;
+
+ bool processing_occluded_now_tiles_;
+ bool processing_soon_border_rect_;
+ std::vector<Tile*> unoccluded_now_tiles_;
+ size_t unoccluded_now_tiles_index_;
+
+ Tile* current_tile_;
+
+ TilingData::Iterator visible_iterator_;
+ TilingData::ReverseSpiralDifferenceIterator spiral_iterator_;
};
~PictureLayerTiling();
@@ -315,10 +329,6 @@ class CC_EXPORT PictureLayerTiling {
const gfx::Rect& visible_rect_in_content_space)
const;
- void UpdateEvictionCacheIfNeeded(TreePriority tree_priority);
- const std::vector<Tile*>* GetEvictionTiles(TreePriority tree_priority,
- EvictionCategory category);
-
void Invalidate(const Region& layer_region);
void DoInvalidate(const Region& layer_region,
@@ -358,19 +368,6 @@ class CC_EXPORT PictureLayerTiling {
Occlusion current_occlusion_in_layer_space_;
- // TODO(reveman): Remove this in favour of an array of eviction_tiles_ when we
- // change all enums to have a consistent way of getting the count/last
- // element.
- std::vector<Tile*> eviction_tiles_now_;
- std::vector<Tile*> eviction_tiles_now_and_required_for_activation_;
- std::vector<Tile*> eviction_tiles_soon_;
- std::vector<Tile*> eviction_tiles_soon_and_required_for_activation_;
- std::vector<Tile*> eviction_tiles_eventually_;
- std::vector<Tile*> eviction_tiles_eventually_and_required_for_activation_;
-
- bool eviction_tiles_cache_valid_;
- TreePriority eviction_cache_tree_priority_;
-
private:
DISALLOW_ASSIGN(PictureLayerTiling);

Powered by Google App Engine
This is Rietveld 408576698