Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 644283003: Add setTextDirection to the ApiCompatibilityUtils. (Closed)

Created:
6 years, 2 months ago by Ted C
Modified:
6 years, 2 months ago
Reviewers:
nyquist
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add setTextDirection to the ApiCompatibilityUtils. Only added in API 17: http://developer.android.com/reference/android/view/View.html#setTextDirection(int) BUG=411056 Committed: https://crrev.com/293dd71010d2d09179ca2e7187bf1dba4d086478 Cr-Commit-Position: refs/heads/master@{#299779}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java View 2 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Ted C
PTAL
6 years, 2 months ago (2014-10-15 17:15:08 UTC) #2
nyquist
lgtm
6 years, 2 months ago (2014-10-15 21:05:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/644283003/1
6 years, 2 months ago (2014-10-15 21:06:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-15 22:05:35 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 22:06:22 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/293dd71010d2d09179ca2e7187bf1dba4d086478
Cr-Commit-Position: refs/heads/master@{#299779}

Powered by Google App Engine
This is Rietveld 408576698