components/predictor/common/predictor_messages.h - Issue 644123002: Componentize renderer side of DNS prefetching.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/predictor/common/predictor_messages.h

Issue 644123002: Componentize renderer side of DNS prefetching. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright (c) 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // Multiply-included file, no traditional include guard.

	6 #include <string>

	7 #include <vector>

	8

	9 #include "ipc/ipc_message_macros.h"

	10 #include "ipc/ipc_message_utils.h"

	11

	12 #define IPC_MESSAGE_START DnsPredictorMsgStart

	13

	14 //-----------------------------------------------------------------------------

	15 // Host messages

	16 // These are messages sent from the browser to the renderer process.

	17

	18 // Request for a DNS prefetch of the names in the array.

	19 // NameList is typedef'ed std::vector<std::string>

	20 IPC_MESSAGE_CONTROL1(DnsPredictorMsg_RequestPrefetch,

	21 std::vector<std::string> /* hostnames */)
	palmer 2014/10/13 23:56:21 Does the receiver of this message set any hard lim Does the receiver of this message set any hard limit on the size of the vector and the sizes of the strings? gunsch 2014/10/14 15:54:38 As far as I can tell, in Chrome's current implemen Show quoted text On 2014/10/13 23:56:21, Chromium Palmer wrote: > Does the receiver of this message set any hard limit on the size of the vector > and the sizes of the strings? As far as I can tell, in Chrome's current implementation, the limit is only enforced on the renderer (sender) side. (which makes me notice the IPC comment was backwards, the IPC message is sent _to_ the browser process). Some light codesearching seems to imply that's the general case, can you point me to some similar receiver-side limits on IPC vectors?
OLD	NEW

« components/predictor/OWNERS ('K') | « components/predictor/common/predictor_message_generator.cc ('k') | components/predictor/renderer/BUILD.gn » ('j') | no next file with comments »