[turbofan] Reduce memory consumption of graph building

test/unittests/compiler/value-numbering-reducer-unittest.cc

Index: test/unittests/compiler/value-numbering-reducer-unittest.cc
diff --git a/test/unittests/compiler/value-numbering-reducer-unittest.cc b/test/unittests/compiler/value-numbering-reducer-unittest.cc
index 7fa3f55ed57f7a3951f2effcfb05da1021e823cf..5ff3befbc1cdddf57bc17eee44545c5824f009bb 100644
--- a/test/unittests/compiler/value-numbering-reducer-unittest.cc
+++ b/test/unittests/compiler/value-numbering-reducer-unittest.cc
@@ -67,8 +67,8 @@ TEST_F(ValueNumberingReducerTest, OperatorEqualityNotIdentity) {
   static const size_t kMaxInputCount = 16;
   Node* inputs[kMaxInputCount];
   for (size_t i = 0; i < arraysize(inputs); ++i) {
-    Operator::Opcode opcode = static_cast<Operator::Opcode>(
-        std::numeric_limits<Operator::Opcode>::max() - i);
+    Operator::Opcode opcode =
+        static_cast<Operator::Opcode>(IrOpcode::kLast - i);

[Benedikt Meurer, 2014/10/27 09:29:14]

What is the purpose of this change?

[Michael Starzinger, 2014/10/27 09:34:19]

Is there any particular reason for this change? I actually would like to get rid
of IrOpcode::kLast completely if we can, it's only used in one assertion AFAICT.

     inputs[i] = graph()->NewNode(new (zone()) SimpleOperator(
         opcode, Operator::kEliminatable, 0, 1, "Operator"));
   }
@@ -95,8 +95,8 @@ TEST_F(ValueNumberingReducerTest, SubsequentReductionsYieldTheSameNode) {
   static const size_t kMaxInputCount = 16;
   Node* inputs[kMaxInputCount];
   for (size_t i = 0; i < arraysize(inputs); ++i) {
-    Operator::Opcode opcode = static_cast<Operator::Opcode>(
-        std::numeric_limits<Operator::Opcode>::max() - i);
+    Operator::Opcode opcode =
+        static_cast<Operator::Opcode>(IrOpcode::kLast - i);

[Benedikt Meurer, 2014/10/27 09:29:14]

What is the purpose of this change?

     inputs[i] = graph()->NewNode(new (zone()) SimpleOperator(
         opcode, Operator::kEliminatable, 0, 1, "Operator"));
   }