Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1344)

Unified Diff: Source/core/rendering/RenderListItem.cpp

Issue 644073002: Avoid layout when list color changes (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/RenderListItem.cpp
diff --git a/Source/core/rendering/RenderListItem.cpp b/Source/core/rendering/RenderListItem.cpp
index 6c251c4263ad53e95a8804e375c1e8ec97d2d89d..4898f8605e99bf55161ea01830cdda2f09e32bb7 100644
--- a/Source/core/rendering/RenderListItem.cpp
+++ b/Source/core/rendering/RenderListItem.cpp
@@ -59,13 +59,9 @@ void RenderListItem::styleDidChange(StyleDifference diff, const RenderStyle* old
if (style()->listStyleType() != NoneListStyle
|| (style()->listStyleImage() && !style()->listStyleImage()->errorOccurred())) {
- RefPtr<RenderStyle> newStyle = RenderStyle::create();
- // The marker always inherits from the list item, regardless of where it might end
- // up (e.g., in some deeply nested line box). See CSS3 spec.
- newStyle->inheritFrom(style());
if (!m_marker)
m_marker = RenderListMarker::createAnonymous(this);
- m_marker->setStyle(newStyle.release());
+ m_marker->listItemStyleDidChange();
} else if (m_marker) {
m_marker->destroy();
m_marker = nullptr;
« no previous file with comments | « LayoutTests/fast/lists/list-color-change-no-layout-expected.txt ('k') | Source/core/rendering/RenderListMarker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698