Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Unified Diff: components/password_manager/core/browser/password_generation_manager_unittest.cc

Issue 644053003: [Password Manager] Add UMA stats for custom passphrase users. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More Mac Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_generation_manager_unittest.cc
diff --git a/components/password_manager/core/browser/password_generation_manager_unittest.cc b/components/password_manager/core/browser/password_generation_manager_unittest.cc
index 044b575a02f8561e1e1ba31531c8a6128de85a3c..80e87b3eb4013152fabf2b24f498fe276ebab7c1 100644
--- a/components/password_manager/core/browser/password_generation_manager_unittest.cc
+++ b/components/password_manager/core/browser/password_generation_manager_unittest.cc
@@ -18,6 +18,7 @@
#include "components/password_manager/core/browser/password_manager.h"
#include "components/password_manager/core/browser/stub_password_manager_client.h"
#include "components/password_manager/core/browser/stub_password_manager_driver.h"
+#include "components/password_manager/core/browser/test_password_store.h"
#include "components/password_manager/core/common/password_manager_pref_names.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "url/gurl.h"
@@ -70,12 +71,21 @@ class TestPasswordManagerDriver : public StubPasswordManagerDriver {
class TestPasswordManagerClient : public StubPasswordManagerClient {
public:
TestPasswordManagerClient(scoped_ptr<PrefService> prefs)
- : prefs_(prefs.Pass()), driver_(this), is_sync_enabled_(false) {}
+ : prefs_(prefs.Pass()),
+ store_(new TestPasswordStore),
+ driver_(this),
+ is_sync_enabled_(false) {}
- PasswordStore* GetPasswordStore() override { return NULL; }
+ ~TestPasswordManagerClient() {
vabr (Chromium) 2014/10/24 06:30:28 Should this also be 'override'?
Garrett Casto 2014/10/24 18:25:03 Good catch. Done.
+ store_->Shutdown();
+ }
+
+ PasswordStore* GetPasswordStore() override { return store_.get(); }
PrefService* GetPrefs() override { return prefs_.get(); }
PasswordManagerDriver* GetDriver() override { return &driver_; }
- bool IsPasswordSyncEnabled() override { return is_sync_enabled_; }
+ bool IsPasswordSyncEnabled(CustomPassphraseState state) override {
+ return is_sync_enabled_;
+ }
void set_is_password_sync_enabled(bool enabled) {
is_sync_enabled_ = enabled;
@@ -83,6 +93,7 @@ class TestPasswordManagerClient : public StubPasswordManagerClient {
private:
scoped_ptr<PrefService> prefs_;
+ scoped_refptr<TestPasswordStore> store_;
TestPasswordManagerDriver driver_;
bool is_sync_enabled_;
};

Powered by Google App Engine
This is Rietveld 408576698