Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client.h

Issue 644053003: [Password Manager] Add UMA stats for custom passphrase users. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More Mac Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/chrome_password_manager_client.h
diff --git a/chrome/browser/password_manager/chrome_password_manager_client.h b/chrome/browser/password_manager/chrome_password_manager_client.h
index f3a2ed03e3fbc9651b59d32d2a537191a29848f7..1cd35819d2a278421b1b0bf6961c1cfac4dfc865 100644
--- a/chrome/browser/password_manager/chrome_password_manager_client.h
+++ b/chrome/browser/password_manager/chrome_password_manager_client.h
@@ -43,6 +43,7 @@ class ChromePasswordManagerClient
bool IsAutomaticPasswordSavingEnabled() const override;
bool IsPasswordManagerEnabledForCurrentPage() const override;
bool ShouldFilterAutofillResult(const autofill::PasswordForm& form) override;
+ std::string GetSyncUsername() const override;
bool IsSyncAccountCredential(const std::string& username,
const std::string& origin) const override;
void AutofillResultsComputed() override;
@@ -59,7 +60,8 @@ class ChromePasswordManagerClient
password_manager::PasswordManagerDriver* GetDriver() override;
base::FieldTrial::Probability GetProbabilityForExperiment(
const std::string& experiment_name) override;
- bool IsPasswordSyncEnabled() override;
+ bool IsPasswordSyncEnabled(
+ password_manager::CustomPassphraseState state) override;
void OnLogRouterAvailabilityChanged(bool router_can_be_used) override;
void LogSavePasswordProgress(const std::string& text) override;
bool IsLoggingActive() const override;

Powered by Google App Engine
This is Rietveld 408576698