components/password_manager/core/browser/password_generation_manager_unittest.cc - Issue 644053003: [Password Manager] Add UMA stats for custom passphrase users.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_generation_manager_unittest.cc

Issue 644053003: [Password Manager] Add UMA stats for custom passphrase users. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/password_manager/core/browser/login_database.cc ('K') | « components/password_manager/core/browser/password_generation_manager.cc ('k') | components/password_manager/core/browser/password_manager.cc » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_generation_manager_unittest.cc

diff --git a/components/password_manager/core/browser/password_generation_manager_unittest.cc b/components/password_manager/core/browser/password_generation_manager_unittest.cc

index 917f50241c2f9fc1af50d28446563f991ae384bf..66b2274fa57164efbb81b4d737a8ef5fe0acf38e 100644

--- a/components/password_manager/core/browser/password_generation_manager_unittest.cc

+++ b/components/password_manager/core/browser/password_generation_manager_unittest.cc

@@ -77,7 +77,9 @@ class TestPasswordManagerClient : public StubPasswordManagerClient {

virtual PasswordStore* GetPasswordStore() override { return NULL; }

virtual PrefService* GetPrefs() override { return prefs_.get(); }

virtual PasswordManagerDriver* GetDriver() override { return &driver_; }

- virtual bool IsPasswordSyncEnabled() override { return is_sync_enabled_; }

+ virtual bool IsPasswordSyncEnabled(CustomPassphraseState state) override {

+ return is_sync_enabled_;

+ }

void set_is_password_sync_enabled(bool enabled) {

is_sync_enabled_ = enabled;