chrome/browser/password_manager/password_store_mac.h - Issue 644053003: [Password Manager] Add UMA stats for custom passphrase users.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_store_mac.h

Issue 644053003: [Password Manager] Add UMA stats for custom passphrase users. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/password_store_factory.cc ('k') | chrome/browser/password_manager/password_store_mac.cc » ('j') | components/password_manager/core/browser/login_database.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/password_store_mac.h

diff --git a/chrome/browser/password_manager/password_store_mac.h b/chrome/browser/password_manager/password_store_mac.h

index 0e1be3d4dd25bf56d43a90312e13c129da27c5e4..3b6811999918b7eea48d6810d94421c0cbf87ce5 100644

--- a/chrome/browser/password_manager/password_store_mac.h

+++ b/chrome/browser/password_manager/password_store_mac.h

@@ -38,8 +38,7 @@ class PasswordStoreMac : public password_manager::PasswordStore {

// Initializes |thread_|.

virtual bool Init(

- const syncer::SyncableService::StartSyncFlare& flare,

- const std::string& sync_username) override;

+ const syncer::SyncableService::StartSyncFlare& flare) override;

// Stops |thread_|.

virtual void Shutdown() override;

@@ -51,7 +50,8 @@ class PasswordStoreMac : public password_manager::PasswordStore {

GetBackgroundTaskRunner() override;

private:

- virtual void ReportMetricsImpl(const std::string& sync_username) override;

+ virtual void ReportMetricsImpl(

+ password_manager::PasswordManagerClient* client) override;

virtual password_manager::PasswordStoreChangeList AddLoginImpl(

const autofill::PasswordForm& form) override;

virtual password_manager::PasswordStoreChangeList UpdateLoginImpl(